From: Eli Zaretskii <eliz@gnu.org>
To: Julien Danjou <julien@danjou.info>
Cc: larsi@gnus.org, emacs-devel@gnu.org
Subject: Re: /srv/bzr/emacs/trunk r102478: shr.el (shr-tag-color-check):Convert colors to hexadecimal with shr-color->hexadecimal.
Date: Wed, 24 Nov 2010 06:35:23 -0500 [thread overview]
Message-ID: <E1PLDdD-00037m-Jb@fencepost.gnu.org> (raw)
In-Reply-To: <87d3pvf5s2.fsf@keller.adm.naquadah.org> (message from Julien Danjou on Wed, 24 Nov 2010 10:08:13 +0100)
> From: Julien Danjou <julien@danjou.info>
> Date: Wed, 24 Nov 2010 10:08:13 +0100
> Cc: 'Lars Magne Ingebrigtsen' <larsi@gnus.org>, emacs-devel@gnu.org
>
> Color-lab has been built upon a specific need, which resulted in the CIE
> Delta E 2000 formula to be implemented. Some helper functions dealing
> with colors have been written, like CIE XYZ and CIE Lab conversion in
> the process.
>
> All of this is not present in hexrgb, and hexrgb is not present in Emacs.
>
> I admit: color-lab has 50 SLOC for 2 functions (rgb->hsl and rgb->hsv)
> which are in hexrgb, but they are even not used at all by the CIE code.
>
> So I think it's really unfair to stand up and point at this package like
> it's something that should not have been done.
>
> Now if you want to merge hexrgb and color-lab, why not, but stop
> pointing at other people work because some is not included in Emacs.
>
> I can't do anything about it.
Perhaps we could all stop being apologetic and pointing fingers at one
another, and see one important lesson to be learned here: that before
adding a package to Emacs, the contributor should talk to the head
maintainers about where the new package should be and whether it
should be a new one or an addition to an existing one.
next prev parent reply other threads:[~2010-11-24 11:35 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1PKgZg-0005td-8L@internal.in.savannah.gnu.org>
2010-11-23 19:50 ` /srv/bzr/emacs/trunk r102478: shr.el (shr-tag-color-check): Convert colors to hexadecimal with shr-color->hexadecimal Glenn Morris
2010-11-23 20:24 ` Chong Yidong
2010-11-23 21:14 ` Julien Danjou
2010-11-23 21:31 ` Chong Yidong
2010-11-23 21:38 ` Lars Magne Ingebrigtsen
2010-11-23 22:18 ` Chong Yidong
2010-11-23 22:34 ` Lars Magne Ingebrigtsen
2010-11-24 0:12 ` /srv/bzr/emacs/trunk r102478: shr.el (shr-tag-color-check):Convert " Drew Adams
2010-11-24 9:08 ` Julien Danjou
2010-11-24 11:35 ` Eli Zaretskii [this message]
2010-11-24 14:46 ` Stefan Monnier
2010-11-24 15:30 ` Lennart Borgman
2010-11-24 18:15 ` Ted Zlatanov
2010-11-24 21:37 ` Lennart Borgman
2010-11-24 22:19 ` Lars Magne Ingebrigtsen
2010-11-24 22:41 ` Use color-tweaking code to improve face defaults? [was: /srv/bzr/emacs/trunk r1...] Drew Adams
2010-11-25 4:53 ` /srv/bzr/emacs/trunk r102478: shr.el (shr-tag-color-check):Convert colors to hexadecimal with shr-color->hexadecimal Stefan Monnier
2010-12-10 19:19 ` Ted Zlatanov
2010-11-24 16:15 ` Drew Adams
2010-11-24 18:11 ` Ted Zlatanov
2010-11-24 21:00 ` /srv/bzr/emacs/trunk r102478: shr.el(shr-tag-color-check):Convert colors to hexadecimal withshr-color->hexadecimal Drew Adams
2010-11-24 21:33 ` Julien Danjou
2010-11-24 21:51 ` Drew Adams
2010-11-24 16:29 ` /srv/bzr/emacs/trunk r102478: shr.el (shr-tag-color-check):Convert colors to hexadecimal with shr-color->hexadecimal Chong Yidong
2010-11-24 0:05 ` Drew Adams
2010-11-24 8:36 ` /srv/bzr/emacs/trunk r102478: shr.el (shr-tag-color-check): Convert " Richard Stallman
2010-11-24 14:42 ` Stefan Monnier
2010-11-23 21:16 ` Lars Magne Ingebrigtsen
2010-11-23 22:19 ` Ted Zlatanov
2010-11-23 21:14 ` Julien Danjou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1PLDdD-00037m-Jb@fencepost.gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=julien@danjou.info \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.