From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: on msdos Date: Thu, 18 Nov 2010 05:26:26 -0500 Message-ID: References: Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1290076007 2954 80.91.229.12 (18 Nov 2010 10:26:47 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 18 Nov 2010 10:26:47 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Nov 18 11:26:41 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PJ1hQ-0003Qa-1D for ged-emacs-devel@m.gmane.org; Thu, 18 Nov 2010 11:26:40 +0100 Original-Received: from localhost ([127.0.0.1]:56588 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PJ1hP-0006S8-Cs for ged-emacs-devel@m.gmane.org; Thu, 18 Nov 2010 05:26:39 -0500 Original-Received: from [140.186.70.92] (port=60788 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PJ1hH-0006Rz-NG for emacs-devel@gnu.org; Thu, 18 Nov 2010 05:26:32 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PJ1hE-0004aW-OJ for emacs-devel@gnu.org; Thu, 18 Nov 2010 05:26:31 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]:45258) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PJ1hE-0004aS-Mv for emacs-devel@gnu.org; Thu, 18 Nov 2010 05:26:28 -0500 Original-Received: from eliz by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1PJ1hC-00023y-My; Thu, 18 Nov 2010 05:26:26 -0500 In-reply-to: (message from Dan Nicolaescu on Wed, 17 Nov 2010 23:42:13 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:132816 Archived-At: > From: Dan Nicolaescu > Date: Wed, 17 Nov 2010 23:42:13 -0500 > > Does msdos have ? It does, but this header defines DOS ioctl stuff, not the Posix ioctl stuff. There's no emulation of the Posix ioctl functionality in the standard C library used to build the DOS port. > In a few places > #ifndef MSDOS > is used to avoid including it. Yes, because doing so pollutes the namespace with gobs of symbols that could get in the way. > Other places use HAVE_SYS_IOCTL_H > process.c includes it unconditionally in the non-msdos part. I see these places where sys/ioctl.h is included in Emacs: - in process.c -- not relevant for MSDOS and included unconditionally - in keyboard.c -- conditioned by MSDOS - in sound.c -- conditioned by MSDOS - in xterm.c -- only relevant for DOS if someone revives the old DOS port of Xlib, which probably won't happen; conditioned by HAVE_SYS_IOCTL_H - in systty.h -- conditioned by HAVE_SYS_IOCTL_H > It would be nicer to include it unconditionally everywhere, or to use > the same conditional everywhere. I could arrange for the MSDOS port to not define HAVE_SYS_IOCTL_H, and then we could use that everywhere.