From: Eli Zaretskii <eliz@gnu.org>
To: Dan Nicolaescu <dann@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: <sys/ioctl.h> on msdos
Date: Thu, 18 Nov 2010 05:26:26 -0500 [thread overview]
Message-ID: <E1PJ1hC-00023y-My@fencepost.gnu.org> (raw)
In-Reply-To: <yxqwrobkztm.fsf@fencepost.gnu.org> (message from Dan Nicolaescu on Wed, 17 Nov 2010 23:42:13 -0500)
> From: Dan Nicolaescu <dann@gnu.org>
> Date: Wed, 17 Nov 2010 23:42:13 -0500
>
> Does msdos have <sys/ioctl.h> ?
It does, but this header defines DOS ioctl stuff, not the Posix ioctl
stuff. There's no emulation of the Posix ioctl functionality in the
standard C library used to build the DOS port.
> In a few places
> #ifndef MSDOS
> is used to avoid including it.
Yes, because doing so pollutes the namespace with gobs of symbols that
could get in the way.
> Other places use HAVE_SYS_IOCTL_H
> process.c includes it unconditionally in the non-msdos part.
I see these places where sys/ioctl.h is included in Emacs:
- in process.c -- not relevant for MSDOS and included unconditionally
- in keyboard.c -- conditioned by MSDOS
- in sound.c -- conditioned by MSDOS
- in xterm.c -- only relevant for DOS if someone revives the old DOS
port of Xlib, which probably won't happen; conditioned by
HAVE_SYS_IOCTL_H
- in systty.h -- conditioned by HAVE_SYS_IOCTL_H
> It would be nicer to include it unconditionally everywhere, or to use
> the same conditional everywhere.
I could arrange for the MSDOS port to not define HAVE_SYS_IOCTL_H, and
then we could use that everywhere.
next prev parent reply other threads:[~2010-11-18 10:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 4:42 <sys/ioctl.h> on msdos Dan Nicolaescu
2010-11-18 10:26 ` Eli Zaretskii [this message]
2010-11-19 17:54 ` Eli Zaretskii
2010-11-20 7:39 ` Dan Nicolaescu
2010-11-20 9:08 ` Eli Zaretskii
2010-11-21 4:40 ` Dan Nicolaescu
2010-11-21 17:45 ` Eli Zaretskii
2010-11-26 12:17 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1PJ1hC-00023y-My@fencepost.gnu.org \
--to=eliz@gnu.org \
--cc=dann@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.