From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: display bug for empty lines in recent git snapshot Date: Wed, 17 Nov 2010 07:54:23 -0500 Message-ID: References: <87hbfgfg9v.fsf@member.fsf.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1289998479 27722 80.91.229.12 (17 Nov 2010 12:54:39 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 17 Nov 2010 12:54:39 +0000 (UTC) Cc: tassilo@member.fsf.org, emacs-devel@gnu.org To: Giorgos Keramidas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 17 13:54:35 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PIhWz-0006u9-1c for ged-emacs-devel@m.gmane.org; Wed, 17 Nov 2010 13:54:33 +0100 Original-Received: from localhost ([127.0.0.1]:39843 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PIhWy-0004uD-Mo for ged-emacs-devel@m.gmane.org; Wed, 17 Nov 2010 07:54:32 -0500 Original-Received: from [140.186.70.92] (port=44146 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PIhWu-0004u8-KO for emacs-devel@gnu.org; Wed, 17 Nov 2010 07:54:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PIhWt-0007qD-Ia for emacs-devel@gnu.org; Wed, 17 Nov 2010 07:54:28 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]:40752) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PIhWr-0007pn-Rg; Wed, 17 Nov 2010 07:54:25 -0500 Original-Received: from eliz by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1PIhWp-00035G-A4; Wed, 17 Nov 2010 07:54:23 -0500 In-reply-to: (message from Giorgos Keramidas on Wed, 17 Nov 2010 11:43:23 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:132780 Archived-At: > From: Giorgos Keramidas > Cc: Tassilo Horn , emacs-devel@gnu.org > Date: Wed, 17 Nov 2010 11:43:23 +0100 > > On Wed, 17 Nov 2010 10:31:08 +0100, Tassilo Horn wrote: > > Hi Giorgos, > > > > I've already filed this as bug#7417. > > The change that introduced this bug in my local mirror of the git trunk > is one committed by Eli on Nov 13: Yes, it's my bad, sorry. Cursor positioning is a tricksy business, with lots of different use-cases. I guess I failed to test the TTY display properly after this change. > I think there's some exception we have to add here for newline > characters, because they are treated as GLYPHLESS_DISPLAY_THIN_SPACE or > as GLYPHLESS_DISPLAY_EMPTY_BOX with a width of 1 space, but I am not > sure what the best way to do this would be. Maybe Eli has a good idea > of how this can be fixed? No, this isn't the problem, I'm quite sure. The problem is that I installed a fix for displaying glyphless characters using the zero-width method (see the change in set_cursor_from_row in the changeset), and that fix inadvertently introduced this bug. I will try to fix this as soon as possible.