From: Eli Zaretskii <eliz@gnu.org>
To: Giorgos Keramidas <keramida@ceid.upatras.gr>
Cc: tassilo@member.fsf.org, emacs-devel@gnu.org
Subject: Re: display bug for empty lines in recent git snapshot
Date: Wed, 17 Nov 2010 07:54:23 -0500 [thread overview]
Message-ID: <E1PIhWp-00035G-A4@fencepost.gnu.org> (raw)
In-Reply-To: <xeia1v6kdyd0.fsf@kobe.laptop> (message from Giorgos Keramidas on Wed, 17 Nov 2010 11:43:23 +0100)
> From: Giorgos Keramidas <keramida@ceid.upatras.gr>
> Cc: Tassilo Horn <tassilo@member.fsf.org>, emacs-devel@gnu.org
> Date: Wed, 17 Nov 2010 11:43:23 +0100
>
> On Wed, 17 Nov 2010 10:31:08 +0100, Tassilo Horn <tassilo@member.fsf.org> wrote:
> > Hi Giorgos,
> >
> > I've already filed this as bug#7417.
>
> The change that introduced this bug in my local mirror of the git trunk
> is one committed by Eli on Nov 13:
Yes, it's my bad, sorry. Cursor positioning is a tricksy business,
with lots of different use-cases. I guess I failed to test the TTY
display properly after this change.
> I think there's some exception we have to add here for newline
> characters, because they are treated as GLYPHLESS_DISPLAY_THIN_SPACE or
> as GLYPHLESS_DISPLAY_EMPTY_BOX with a width of 1 space, but I am not
> sure what the best way to do this would be. Maybe Eli has a good idea
> of how this can be fixed?
No, this isn't the problem, I'm quite sure.
The problem is that I installed a fix for displaying glyphless
characters using the zero-width method (see the change in
set_cursor_from_row in the changeset), and that fix inadvertently
introduced this bug.
I will try to fix this as soon as possible.
next prev parent reply other threads:[~2010-11-17 12:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 9:10 display bug for empty lines in recent git snapshot Giorgos Keramidas
2010-11-17 9:31 ` Tassilo Horn
2010-11-17 9:50 ` Giorgos Keramidas
2010-11-17 10:43 ` Giorgos Keramidas
2010-11-17 12:54 ` Eli Zaretskii [this message]
2010-11-17 13:14 ` Giorgos Keramidas
2010-11-17 19:20 ` Eli Zaretskii
2010-11-17 20:12 ` Giorgos Keramidas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1PIhWp-00035G-A4@fencepost.gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=keramida@ceid.upatras.gr \
--cc=tassilo@member.fsf.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.