From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: ns-win.el Date: Tue, 26 Oct 2010 03:47:23 -0400 Message-ID: References: <19651.37838.815906.240014@fencepost.gnu.org> <7seibdzmke.fsf@fencepost.gnu.org> <6B12217D-6FF2-42FE-A53C-AAA32C7AC510@gmail.com> <6geibdtpty.fsf@fencepost.gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1288080368 22271 80.91.229.12 (26 Oct 2010 08:06:08 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 26 Oct 2010 08:06:08 +0000 (UTC) Cc: dann@gnu.org, adrian.b.robert@gmail.com, emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 26 10:06:06 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PAeXj-0004E5-U3 for ged-emacs-devel@m.gmane.org; Tue, 26 Oct 2010 10:06:04 +0200 Original-Received: from localhost ([127.0.0.1]:43589 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PAeXi-0005Bs-Rl for ged-emacs-devel@m.gmane.org; Tue, 26 Oct 2010 04:06:03 -0400 Original-Received: from [140.186.70.92] (port=51538 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PAeFo-0007VC-2X for emacs-devel@gnu.org; Tue, 26 Oct 2010 03:47:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PAeFh-0000Sv-6y for emacs-devel@gnu.org; Tue, 26 Oct 2010 03:47:31 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:33963) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PAeFh-0000Sr-5T for emacs-devel@gnu.org; Tue, 26 Oct 2010 03:47:25 -0400 Original-Received: from eliz by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1PAeFf-0007TD-BJ; Tue, 26 Oct 2010 03:47:23 -0400 In-reply-to: <6geibdtpty.fsf@fencepost.gnu.org> (message from Glenn Morris on Tue, 26 Oct 2010 02:45:13 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:132127 Archived-At: > From: Glenn Morris > Date: Tue, 26 Oct 2010 02:45:13 -0400 > Cc: Dan Nicolaescu , emacs-devel@gnu.org > > > On the other hand, they were moved from menu-bar.el TO ns-win.el > > during the merge. It was desired to keep these platform-specific > > things in the platform-specific file rather than cluttering up > > common files, and I've come to agree myself this is the best way. > > Whoops. I have to say I disagree, since it is more work to change the > menus after they are defined, and it means requiring easymenu in the > dumped ns Emacs; and this means putting it in the DOC file for every > platform. I also find it much easier to see all the menu definitions at > one place rather than have them scattered over multiple files. FWIW, I agree. There's no need to limit platform-specific stuff to just a handful of platform-specific files. We have a lot of platform conditionals in many common Lisp files, and I see nothing wrong with that. By contrast, looking in *-win.el for something belonging to the menu bar would be counter-intuitive, IMO.