From: Eli Zaretskii <eliz@gnu.org>
To: Glenn Morris <rgm@gnu.org>
Cc: dann@gnu.org, adrian.b.robert@gmail.com, emacs-devel@gnu.org
Subject: Re: ns-win.el
Date: Tue, 26 Oct 2010 03:47:23 -0400 [thread overview]
Message-ID: <E1PAeFf-0007TD-BJ@fencepost.gnu.org> (raw)
In-Reply-To: <6geibdtpty.fsf@fencepost.gnu.org> (message from Glenn Morris on Tue, 26 Oct 2010 02:45:13 -0400)
> From: Glenn Morris <rgm@gnu.org>
> Date: Tue, 26 Oct 2010 02:45:13 -0400
> Cc: Dan Nicolaescu <dann@gnu.org>, emacs-devel@gnu.org
>
> > On the other hand, they were moved from menu-bar.el TO ns-win.el
> > during the merge. It was desired to keep these platform-specific
> > things in the platform-specific file rather than cluttering up
> > common files, and I've come to agree myself this is the best way.
>
> Whoops. I have to say I disagree, since it is more work to change the
> menus after they are defined, and it means requiring easymenu in the
> dumped ns Emacs; and this means putting it in the DOC file for every
> platform. I also find it much easier to see all the menu definitions at
> one place rather than have them scattered over multiple files.
FWIW, I agree. There's no need to limit platform-specific stuff to
just a handful of platform-specific files. We have a lot of platform
conditionals in many common Lisp files, and I see nothing wrong with
that. By contrast, looking in *-win.el for something belonging to the
menu bar would be counter-intuitive, IMO.
next prev parent reply other threads:[~2010-10-26 7:47 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1P9lT2-0005WD-37@internal.in.savannah.gnu.org>
[not found] ` <jwvmxq4pez1.fsf-monnier+emacs@gnu.org>
2010-10-24 2:02 ` [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc Glenn Morris
2010-10-24 5:08 ` Dan Nicolaescu
2010-10-24 19:45 ` Glenn Morris
2010-10-25 13:25 ` Adrian Robert
2010-10-25 14:51 ` Dan Nicolaescu
2010-10-26 2:59 ` ns-win.el [was Re: [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc.] Glenn Morris
2010-10-26 4:25 ` ns-win.el Glenn Morris
2010-10-26 4:54 ` ns-win.el CHENG Gao
2010-10-26 5:10 ` ns-win.el Adrian Robert
2010-10-26 15:18 ` ns-win.el Stefan Monnier
2010-10-26 5:07 ` ns-win.el [was Re: [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc.] Adrian Robert
2010-10-26 6:45 ` ns-win.el Glenn Morris
2010-10-26 7:47 ` Eli Zaretskii [this message]
2010-10-26 10:49 ` ns-win.el Adrian Robert
2010-10-26 15:27 ` ns-win.el Stefan Monnier
2010-10-26 19:25 ` ns-win.el Glenn Morris
2010-10-26 19:57 ` ns-win.el Adrian Robert
2010-10-26 6:50 ` ns-win.el Glenn Morris
2010-10-26 7:49 ` ns-win.el Eli Zaretskii
2010-10-26 13:08 ` ns-win.el Ted Zlatanov
2010-10-26 14:42 ` ns-win.el Eli Zaretskii
2010-10-26 17:35 ` ns-win.el Ted Zlatanov
2010-10-26 7:32 ` ns-win.el Daniel Pittman
2010-10-24 7:55 ` [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc Eli Zaretskii
2010-10-24 19:47 ` Glenn Morris
2010-10-25 0:54 ` Stefan Monnier
2010-10-25 4:56 ` Glenn Morris
2010-10-25 8:03 ` Stephen J. Turnbull
2010-10-25 9:28 ` Eli Zaretskii
2010-10-25 8:20 ` Eli Zaretskii
2010-10-28 3:54 ` moving x-select* [was Re: [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc.] Glenn Morris
2010-10-28 4:06 ` Eli Zaretskii
2010-10-28 5:32 ` Jason Rumney
2010-10-28 6:40 ` Chad Brown
2010-10-28 13:54 ` moving x-select* Jason Rumney
2010-10-28 15:28 ` Chad Brown
2010-10-28 14:23 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1PAeFf-0007TD-BJ@fencepost.gnu.org \
--to=eliz@gnu.org \
--cc=adrian.b.robert@gmail.com \
--cc=dann@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.