From: Eli Zaretskii <eliz@gnu.org>
To: "Stephen J. Turnbull" <stephen@xemacs.org>
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc.
Date: Mon, 25 Oct 2010 05:28:28 -0400 [thread overview]
Message-ID: <E1PAJLw-00031i-Nb@fencepost.gnu.org> (raw)
In-Reply-To: <87r5fed7hf.fsf@uwakimon.sk.tsukuba.ac.jp> (stephen@xemacs.org)
> From: "Stephen J. Turnbull" <stephen@xemacs.org>
> Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
> Eli Zaretskii <eliz@gnu.org>,
> emacs-devel@gnu.org
> Date: Mon, 25 Oct 2010 17:03:40 +0900
>
> It's true that for very similar display types such as Xt and GTK+
> where much of the code can be reused[1], it may make sense to create a
> single file with the common code, and include it multiple times with
> preprocessor tweaking to make the names fit and to register driver
> functions in the right tables. But there's no point in this for X
> drivers vs. MS Windows drivers; they're going to have very little
> common code.
Actually, the common code is quite abundant, because the back-end
specific code is not well separated from the platform independent code
that manipulates Emacs internal objects. This causes maintenance
headaches, whereby work on the same bug or feature needs to be done in
several places.
E.g., I recently discovered that various bugfixes and new features
introduced into mouse highlight were done only in the GUI parts of the
display engine, even though the TTY display also supports mouse
highlight (with GPM). This was because the TTY code used a slightly
tailored version of a function that was originally written for in
xterm.c. Then the GUI variant of that function was developed, while
the TTY variant was simply forgotten in its original shape.
So keeping the common code common makes sense even if Emacs will never
be used on X and MS-Windows in the same session, and even if the
back-ends are very different.
next prev parent reply other threads:[~2010-10-25 9:28 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1P9lT2-0005WD-37@internal.in.savannah.gnu.org>
[not found] ` <jwvmxq4pez1.fsf-monnier+emacs@gnu.org>
2010-10-24 2:02 ` [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc Glenn Morris
2010-10-24 5:08 ` Dan Nicolaescu
2010-10-24 19:45 ` Glenn Morris
2010-10-25 13:25 ` Adrian Robert
2010-10-25 14:51 ` Dan Nicolaescu
2010-10-26 2:59 ` ns-win.el [was Re: [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc.] Glenn Morris
2010-10-26 4:25 ` ns-win.el Glenn Morris
2010-10-26 4:54 ` ns-win.el CHENG Gao
2010-10-26 5:10 ` ns-win.el Adrian Robert
2010-10-26 15:18 ` ns-win.el Stefan Monnier
2010-10-26 5:07 ` ns-win.el [was Re: [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc.] Adrian Robert
2010-10-26 6:45 ` ns-win.el Glenn Morris
2010-10-26 7:47 ` ns-win.el Eli Zaretskii
2010-10-26 10:49 ` ns-win.el Adrian Robert
2010-10-26 15:27 ` ns-win.el Stefan Monnier
2010-10-26 19:25 ` ns-win.el Glenn Morris
2010-10-26 19:57 ` ns-win.el Adrian Robert
2010-10-26 6:50 ` ns-win.el Glenn Morris
2010-10-26 7:49 ` ns-win.el Eli Zaretskii
2010-10-26 13:08 ` ns-win.el Ted Zlatanov
2010-10-26 14:42 ` ns-win.el Eli Zaretskii
2010-10-26 17:35 ` ns-win.el Ted Zlatanov
2010-10-26 7:32 ` ns-win.el Daniel Pittman
2010-10-24 7:55 ` [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc Eli Zaretskii
2010-10-24 19:47 ` Glenn Morris
2010-10-25 0:54 ` Stefan Monnier
2010-10-25 4:56 ` Glenn Morris
2010-10-25 8:03 ` Stephen J. Turnbull
2010-10-25 9:28 ` Eli Zaretskii [this message]
2010-10-25 8:20 ` Eli Zaretskii
2010-10-28 3:54 ` moving x-select* [was Re: [Emacs-diffs] /srv/bzr/emacs/trunk r102057: Make all 3 copies of x-select-enable-clipboard have the same doc.] Glenn Morris
2010-10-28 4:06 ` Eli Zaretskii
2010-10-28 5:32 ` Jason Rumney
2010-10-28 6:40 ` Chad Brown
2010-10-28 13:54 ` moving x-select* Jason Rumney
2010-10-28 15:28 ` Chad Brown
2010-10-28 14:23 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1PAJLw-00031i-Nb@fencepost.gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=stephen@xemacs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.