From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix D-Bus string encoding. Date: Wed, 09 Jun 2010 21:56:24 -0400 Message-ID: References: <87typdnr08.fsf@keller.adm.naquadah.org> <1276074981-8930-1-git-send-email-julien@danjou.info> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1276134995 19721 80.91.229.12 (10 Jun 2010 01:56:35 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 10 Jun 2010 01:56:35 +0000 (UTC) Cc: julien@danjou.info, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jun 10 03:56:33 2010 connect(): No such file or directory Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OMX0S-00081i-90 for ged-emacs-devel@m.gmane.org; Thu, 10 Jun 2010 03:56:32 +0200 Original-Received: from localhost ([127.0.0.1]:48676 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMX0R-0002pB-ON for ged-emacs-devel@m.gmane.org; Wed, 09 Jun 2010 21:56:31 -0400 Original-Received: from [199.232.76.173] (port=44280 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OMX0N-0002ow-4A for emacs-devel@gnu.org; Wed, 09 Jun 2010 21:56:27 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1OMX0M-0005GJ-1G for emacs-devel@gnu.org; Wed, 09 Jun 2010 21:56:26 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:36337) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1OMX0L-0005GF-Rv for emacs-devel@gnu.org; Wed, 09 Jun 2010 21:56:25 -0400 Original-Received: from eliz by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1OMX0K-0004Kz-IO; Wed, 09 Jun 2010 21:56:24 -0400 In-reply-to: (message from Stefan Monnier on Wed, 09 Jun 2010 20:20:10 -0400) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:125693 Archived-At: > From: Stefan Monnier > Date: Wed, 09 Jun 2010 20:20:10 -0400 > Cc: emacs-devel@gnu.org > > > + * dbusbind.c (xd_append_arg): Fix string encoding: it has to be > > + valid UTF-8. > > Thanks, I installed a slightly different fix which just uses the > string's bytes (internally stored in utf-8 already) I agree with Andreas here: we should not output unencoded internal representation of characters. If nothing else, it will be a maintenance burden if and when we decide to change something in the internal representation, or if dbus will ever accept binary data. I don't really understand why you insist on doing this over objections, even though functionally both approaches are currently equivalent.