From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Eli Zaretskii <eliz@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: Bug with UTF-8 string and dbus
Date: Tue, 08 Jun 2010 21:17:02 -0400
Message-ID: <E1OM9ug-0003UN-9t@fencepost.gnu.org>
References: <87typdnr08.fsf@keller.adm.naquadah.org>
	<jwvr5kh82ad.fsf-monnier+emacs@gnu.org>
Reply-To: Eli Zaretskii <eliz@gnu.org>
NNTP-Posting-Host: lo.gmane.org
X-Trace: dough.gmane.org 1276046240 16716 80.91.229.12 (9 Jun 2010 01:17:20 GMT)
X-Complaints-To: usenet@dough.gmane.org
NNTP-Posting-Date: Wed, 9 Jun 2010 01:17:20 +0000 (UTC)
Cc: julien@danjou.info, emacs-devel@gnu.org
To: Stefan Monnier <monnier@iro.umontreal.ca>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 09 03:17:17 2010
connect(): No such file or directory
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([199.232.76.165])
	by lo.gmane.org with esmtp (Exim 4.69)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>)
	id 1OM9uq-0001hI-1h
	for ged-emacs-devel@m.gmane.org; Wed, 09 Jun 2010 03:17:12 +0200
Original-Received: from localhost ([127.0.0.1]:44300 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1OM9uo-0007lf-AV
	for ged-emacs-devel@m.gmane.org; Tue, 08 Jun 2010 21:17:10 -0400
Original-Received: from [199.232.76.173] (port=42396 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OM9uj-0007kP-2o
	for emacs-devel@gnu.org; Tue, 08 Jun 2010 21:17:05 -0400
Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <eliz@gnu.org>) id 1OM9ui-0003Sv-8g
	for emacs-devel@gnu.org; Tue, 08 Jun 2010 21:17:05 -0400
Original-Received: from fencepost.gnu.org ([140.186.70.10]:37139)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <eliz@gnu.org>) id 1OM9ui-0003Sr-2l
	for emacs-devel@gnu.org; Tue, 08 Jun 2010 21:17:04 -0400
Original-Received: from eliz by fencepost.gnu.org with local (Exim 4.69)
	(envelope-from <eliz@gnu.org>)
	id 1OM9ug-0003UN-9t; Tue, 08 Jun 2010 21:17:02 -0400
In-reply-to: <jwvr5kh82ad.fsf-monnier+emacs@gnu.org> (message from Stefan
	Monnier on Tue, 08 Jun 2010 20:43:37 -0400)
X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:125649
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/125649>

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Tue, 08 Jun 2010 20:43:37 -0400
> Cc: emacs-devel@gnu.org
> 
> > 492		  char *val = SDATA (Fstring_make_unibyte (object));
> 
> Fstring_make_unibyte is wrong here.
> Most likely, if the D-Bus specification mandates UTF-8, the better thing
> to do would be either to encode using utf-8, or to take advantage of the
> fact that Emacs already uses utf-8 internally and pass just SDATA (object).

Using unencoded SDATA would be wrong with eight-bit characters (aka
raw bytes).  I'd suggest to encode, to be on the safe side.