From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Alfred M. Szmidt" Newsgroups: gmane.emacs.devel Subject: Re: Commit netiquette. Date: Fri, 19 Feb 2010 03:17:48 -0500 Message-ID: References: <87eikjzaug.fsf@telefonica.net> Reply-To: ams@gnu.org NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1266567483 1292 80.91.229.12 (19 Feb 2010 08:18:03 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 19 Feb 2010 08:18:03 +0000 (UTC) Cc: ofv@wanadoo.es, lekktu@gmail.com, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 19 09:18:00 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1NiO3g-0006fb-PN for ged-emacs-devel@m.gmane.org; Fri, 19 Feb 2010 09:17:57 +0100 Original-Received: from localhost ([127.0.0.1]:36581 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NiO3g-0001LS-1m for ged-emacs-devel@m.gmane.org; Fri, 19 Feb 2010 03:17:56 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NiO3b-0001Jp-3F for emacs-devel@gnu.org; Fri, 19 Feb 2010 03:17:51 -0500 Original-Received: from [199.232.76.173] (port=34290 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NiO3a-0001JS-P4 for emacs-devel@gnu.org; Fri, 19 Feb 2010 03:17:50 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NiO3Z-0000Mj-A2 for emacs-devel@gnu.org; Fri, 19 Feb 2010 03:17:50 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]:48978) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NiO3Z-0000Md-3d for emacs-devel@gnu.org; Fri, 19 Feb 2010 03:17:49 -0500 Original-Received: from ams by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1NiO3Y-0005JS-8Y; Fri, 19 Feb 2010 03:17:48 -0500 In-reply-to: (message from Stefan Monnier on Thu, 18 Feb 2010 11:14:43 -0500) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:121218 Archived-At: >> This seems more of a short comming in `bzr log --short' than in the >> way one writes commit messages. Not really: it's the whole idea behing "bzr log --short". bzr log could create a short output in some other fashion, one line is always often to short to explain a change anyway so this option does not do much good. Could someone update log-edit-mode's font-lock patterns so that the first line is highlighted specially (at least in the Bzr and Arch cases)? I think log-edit-mode should even go further in this direction. The buffer should be created as ---------------- Author: Summary: blablabla ---------------- where is the text taken from the ChangeLog. Then for backends which support the notion of summary-line, C-c C-c could just signal an error if the Summary line is still blank. That seems overly forceful, emacs is not just by emacs developers, it is used by an immense number of people. There have been many changes done recently that have not been thought through, nor discussed with those who use emacs. Please stop making such rash decisions; remeber such changes not only affect you by anyone who uses emacs. After that, empty header entries will get removed and the text is passed as-is to the backend who is then free to pass it as-is to the underlying VCS or to extract the various fields and do whatever it feels like with them. This will not help those who use C-c C-a in vc-mode. A sensible way of attacking the problem would be to have a frob, log-edit-message-style, this could be set using .dir-locals.el, per file, or in .emacs. It would affect how C-c C-a behaves, if it inserts a ChangeLog entry the standard way, or if it also adds an header.