From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.devel Subject: Re: bug fix for display property of the form ((height 0.5)) Date: Wed, 29 Jul 2009 09:34:42 +0900 Message-ID: References: <87r5w0svlg.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1248827705 8516 80.91.229.12 (29 Jul 2009 00:35:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 29 Jul 2009 00:35:05 +0000 (UTC) Cc: emacs-devel@gnu.org To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 29 02:34:59 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MVx8E-0003fj-DI for ged-emacs-devel@m.gmane.org; Wed, 29 Jul 2009 02:34:58 +0200 Original-Received: from localhost ([127.0.0.1]:57705 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MVx8D-0007dd-St for ged-emacs-devel@m.gmane.org; Tue, 28 Jul 2009 20:34:57 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MVx89-0007dR-HH for emacs-devel@gnu.org; Tue, 28 Jul 2009 20:34:53 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MVx85-0007YP-Nk for emacs-devel@gnu.org; Tue, 28 Jul 2009 20:34:53 -0400 Original-Received: from [199.232.76.173] (port=44622 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MVx85-0007YM-Kz for emacs-devel@gnu.org; Tue, 28 Jul 2009 20:34:49 -0400 Original-Received: from mx1.aist.go.jp ([150.29.246.133]:43848) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MVx84-0002lS-SB for emacs-devel@gnu.org; Tue, 28 Jul 2009 20:34:49 -0400 Original-Received: from rqsmtp2.aist.go.jp (rqsmtp2.aist.go.jp [150.29.254.123]) by mx1.aist.go.jp with ESMTP id n6T0Yicm023278; Wed, 29 Jul 2009 09:34:44 +0900 (JST) env-from (handa@m17n.org) Original-Received: from smtp2.aist.go.jp by rqsmtp2.aist.go.jp with ESMTP id n6T0YiYq026269; Wed, 29 Jul 2009 09:34:44 +0900 (JST) env-from (handa@m17n.org) Original-Received: by smtp2.aist.go.jp with ESMTP id n6T0YgJA016957; Wed, 29 Jul 2009 09:34:42 +0900 (JST) env-from (handa@m17n.org) Original-Received: from handa by etlken with local (Exim 4.69) (envelope-from ) id 1MVx7y-0006kU-4r; Wed, 29 Jul 2009 09:34:42 +0900 In-reply-to: <87r5w0svlg.fsf@stupidchicken.com> (message from Chong Yidong on Tue, 28 Jul 2009 10:58:19 -0400) X-detected-operating-system: by monty-python.gnu.org: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:113306 Archived-At: In article <87r5w0svlg.fsf@stupidchicken.com>, Chong Yidong writes: > Kenichi Handa writes: > > I've just installed the attached fix for the trunk to fix > > the problem of something like this doesn't work. > > > > (insert (propertize "abc" 'display '((height 0.5)))) > > > > Should I install it for the branch too? > On second thought, the fix looks extremely safe, since only one place in > the code calls face_with_height. I agree. But, in general, face-and-font handling code is so delicate that any change that looks simple may leads to another bug. :-( > I see that you checked it into the branch already; thanks. Oops, it was my mistake. I didn't intend to install it to the branch without the maintainers approval. --- Kenichi Handa handa@m17n.org