From: Kenichi Handa <handa@m17n.org>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: emacs-devel@gnu.org
Subject: Re: bug fix for display property of the form ((height 0.5))
Date: Wed, 29 Jul 2009 09:34:42 +0900 [thread overview]
Message-ID: <E1MVx7y-0006kU-4r@etlken> (raw)
In-Reply-To: <87r5w0svlg.fsf@stupidchicken.com> (message from Chong Yidong on Tue, 28 Jul 2009 10:58:19 -0400)
In article <87r5w0svlg.fsf@stupidchicken.com>, Chong Yidong <cyd@stupidchicken.com> writes:
> Kenichi Handa <handa@m17n.org> writes:
> > I've just installed the attached fix for the trunk to fix
> > the problem of something like this doesn't work.
> >
> > (insert (propertize "abc" 'display '((height 0.5))))
> >
> > Should I install it for the branch too?
> On second thought, the fix looks extremely safe, since only one place in
> the code calls face_with_height.
I agree. But, in general, face-and-font handling code is so
delicate that any change that looks simple may leads to
another bug. :-(
> I see that you checked it into the branch already; thanks.
Oops, it was my mistake. I didn't intend to install it to
the branch without the maintainers approval.
---
Kenichi Handa
handa@m17n.org
prev parent reply other threads:[~2009-07-29 0:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-27 4:32 bug fix for display property of the form ((height 0.5)) Kenichi Handa
2009-07-28 14:55 ` Chong Yidong
2009-07-28 14:58 ` Chong Yidong
2009-07-29 0:34 ` Kenichi Handa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1MVx7y-0006kU-4r@etlken \
--to=handa@m17n.org \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.