* bug#3372: 23.0.94; Wrong input of umlauts in table mode
2009-05-25 6:22 ` bug#3372: 23.0.94; Wrong input of umlauts in table mode Uwe Siart
@ 2009-05-25 7:45 ` Kenichi Handa
2009-05-26 3:40 ` bug#3372: marked as done (23.0.94; Wrong input of umlauts in table mode) Emacs bug Tracking System
1 sibling, 0 replies; 3+ messages in thread
From: Kenichi Handa @ 2009-05-25 7:45 UTC (permalink / raw)
To: uwe.siart, 3372; +Cc: Takaaki.Ota
In article <87octhln0v.fsf@tum.de>, Uwe Siart <uwe.siart@tum.de> writes:
> When I try to enter german umlauts (ä,ö,ü) in table mode I get octal sequences
> instead. Typing »ä« results in display of »\344« etc. Everything is fine when
> table mode is off.
The attached patch will fix that bug.
---
Kenichi Handa
handa@m17n.org
--- table.el.~1.39.~ 2009-01-09 13:19:13.000000000 +0900
+++ table.el 2009-05-25 16:43:03.000000000 +0900
@@ -3943,7 +3943,7 @@
(defun *table--cell-self-insert-command ()
"Table cell version of `self-insert-command'."
(interactive "*")
- (let ((char (table--unibyte-char-to-multibyte last-command-event)))
+ (let ((char last-command-event))
(if (eq buffer-undo-list t) nil
(if (not (eq last-command this-command))
(setq table-cell-self-insert-command-count 0)
@@ -4048,7 +4048,7 @@
(defun *table--cell-quoted-insert (arg)
"Table cell version of `quoted-insert'."
(interactive "*p")
- (let ((char (table--unibyte-char-to-multibyte (read-quoted-char))))
+ (let ((char (read-quoted-char)))
(while (> arg 0)
(table--cell-insert-char char nil)
(setq arg (1- arg)))))
@@ -4349,19 +4349,6 @@
(cdr (symbol-value (cdr prompt-history)))))
(car (symbol-value (cdr prompt-history))))
-(defun table--unibyte-char-to-multibyte (char)
- "Convert CHAR by `unibyte-char-to-multibyte' when possible and necessary."
- ;; This part is take from `quoted-insert'.
- ;; Assume character codes 0240 - 0377 stand for characters in some
- ;; single-byte character set, and convert them to Emacs
- ;; characters.
- (if (and enable-multibyte-characters
- (fboundp 'unibyte-char-to-multibyte)
- (>= char ?\240)
- (<= char ?\377))
- (unibyte-char-to-multibyte char)
- char))
-
(defun table--buffer-substring-and-trim (beg end)
"Extract buffer substring and remove blanks from front and the rear of it."
(save-excursion
^ permalink raw reply [flat|nested] 3+ messages in thread* bug#3372: marked as done (23.0.94; Wrong input of umlauts in table mode)
2009-05-25 6:22 ` bug#3372: 23.0.94; Wrong input of umlauts in table mode Uwe Siart
2009-05-25 7:45 ` Kenichi Handa
@ 2009-05-26 3:40 ` Emacs bug Tracking System
1 sibling, 0 replies; 3+ messages in thread
From: Emacs bug Tracking System @ 2009-05-26 3:40 UTC (permalink / raw)
To: Chong Yidong
[-- Attachment #1: Type: text/plain, Size: 886 bytes --]
Your message dated Mon, 25 May 2009 23:32:31 -0400
with message-id <874ov8cze8.fsf@cyd.mit.edu>
and subject line Re: bug#3372: 23.0.94; Wrong input of umlauts in table mode
has caused the Emacs bug report #3372,
regarding 23.0.94; Wrong input of umlauts in table mode
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)
--
3372: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3372
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems
[-- Attachment #2: Type: message/rfc822, Size: 3935 bytes --]
From: Uwe Siart <uwe.siart@tum.de>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.94; Wrong input of umlauts in table mode
Date: Mon, 25 May 2009 08:22:40 +0200
Message-ID: <87octhln0v.fsf@tum.de>
When I try to enter german umlauts (ä,ö,ü) in table mode I get octal sequences
instead. Typing »ä« results in display of »\344« etc. Everything is fine when
table mode is off.
Regards
Uwe
In GNU Emacs 23.0.94.1 (i386-mingw-nt5.0.2195)
of 2009-05-24 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.0.2195
configured using `configure --with-gcc (3.4)'
Important settings:
value of $LC_ALL: nil
value of $LC_COLLATE: nil
value of $LC_CTYPE: nil
value of $LC_MESSAGES: nil
value of $LC_MONETARY: nil
value of $LC_NUMERIC: nil
value of $LC_TIME: nil
value of $LANG: DEU
value of $XMODIFIERS: nil
locale-coding-system: cp1252
default-enable-multibyte-characters: t
Major mode: Lisp Interaction
Minor modes in effect:
iswitchb-mode: t
display-time-mode: t
auto-insert-mode: t
diff-auto-refine-mode: t
delete-selection-mode: t
pc-selection-mode: t
tooltip-mode: t
mouse-wheel-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
global-auto-composition-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
column-number-mode: t
line-number-mode: t
transient-mark-mode: t
Recent input:
C-x r b s e m <tab> <return> <down> <down> <right>
<right> <right> <right> <right> <right> <right> <right>
<right> <right> C-c t r C-h m <help-echo> <help-echo>
C-x 1 C-x k <return> M-x s u b m i t <tab> <tab> <backspace>
<backspace> <backspace> <backspace> <backspace> <backspace>
C-g C-h a b u g <tab> <backspace> <return> <help-echo>
<help-echo> <wheel-down> <double-wheel-down> <help-echo>
C-g <down> <up> q <down> <up> <up> <down> <backspace>
C-x 1 M-x r e p o <tab> r <tab> <return>
Recent messages:
Type C-x 1 to remove help window.
Quit
Type C-x 1 to remove help window.
Quit
line-move-visual: End of buffer
line-move-visual: Beginning of buffer
line-move-visual: End of buffer
line-move-visual: Beginning of buffer [2 times]
line-move-visual: End of buffer
Making completion list...
[-- Attachment #3: Type: message/rfc822, Size: 1616 bytes --]
From: Chong Yidong <cyd@stupidchicken.com>
To: Kenichi Handa <handa@m17n.org>
Cc: 3372-done@emacsbugs.donarmstrong.com, uwe.siart@tum.de, Takaaki.Ota@am.sony.com
Subject: Re: bug#3372: 23.0.94; Wrong input of umlauts in table mode
Date: Mon, 25 May 2009 23:32:31 -0400
Message-ID: <874ov8cze8.fsf@cyd.mit.edu>
> In article <87octhln0v.fsf@tum.de>, Uwe Siart <uwe.siart@tum.de> writes:
>
> > When I try to enter german umlauts (ä,ö,ü) in table mode I get octal
> > sequences
> > instead. Typing »ä« results in display of »\344« etc. Everything is
> > fine when
> > table mode is off.
>
> The attached patch will fix that bug.
Thanks. This seems clearly correct, so I went ahead and checked it in.
^ permalink raw reply [flat|nested] 3+ messages in thread