From: Kenichi Handa <handa@m17n.org>
To: uwe.siart@tum.de, 3372@emacsbugs.donarmstrong.com
Cc: Takaaki.Ota@am.sony.com
Subject: bug#3372: 23.0.94; Wrong input of umlauts in table mode
Date: Mon, 25 May 2009 16:45:01 +0900 [thread overview]
Message-ID: <E1M8Url-0006ev-84@etlken> (raw)
In-Reply-To: <87octhln0v.fsf@tum.de> (message from Uwe Siart on Mon, 25 May 2009 08:22:40 +0200)
In article <87octhln0v.fsf@tum.de>, Uwe Siart <uwe.siart@tum.de> writes:
> When I try to enter german umlauts (ä,ö,ü) in table mode I get octal sequences
> instead. Typing »ä« results in display of »\344« etc. Everything is fine when
> table mode is off.
The attached patch will fix that bug.
---
Kenichi Handa
handa@m17n.org
--- table.el.~1.39.~ 2009-01-09 13:19:13.000000000 +0900
+++ table.el 2009-05-25 16:43:03.000000000 +0900
@@ -3943,7 +3943,7 @@
(defun *table--cell-self-insert-command ()
"Table cell version of `self-insert-command'."
(interactive "*")
- (let ((char (table--unibyte-char-to-multibyte last-command-event)))
+ (let ((char last-command-event))
(if (eq buffer-undo-list t) nil
(if (not (eq last-command this-command))
(setq table-cell-self-insert-command-count 0)
@@ -4048,7 +4048,7 @@
(defun *table--cell-quoted-insert (arg)
"Table cell version of `quoted-insert'."
(interactive "*p")
- (let ((char (table--unibyte-char-to-multibyte (read-quoted-char))))
+ (let ((char (read-quoted-char)))
(while (> arg 0)
(table--cell-insert-char char nil)
(setq arg (1- arg)))))
@@ -4349,19 +4349,6 @@
(cdr (symbol-value (cdr prompt-history)))))
(car (symbol-value (cdr prompt-history))))
-(defun table--unibyte-char-to-multibyte (char)
- "Convert CHAR by `unibyte-char-to-multibyte' when possible and necessary."
- ;; This part is take from `quoted-insert'.
- ;; Assume character codes 0240 - 0377 stand for characters in some
- ;; single-byte character set, and convert them to Emacs
- ;; characters.
- (if (and enable-multibyte-characters
- (fboundp 'unibyte-char-to-multibyte)
- (>= char ?\240)
- (<= char ?\377))
- (unibyte-char-to-multibyte char)
- char))
-
(defun table--buffer-substring-and-trim (beg end)
"Extract buffer substring and remove blanks from front and the rear of it."
(save-excursion
next prev parent reply other threads:[~2009-05-25 7:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <874ov8cze8.fsf@cyd.mit.edu>
2009-05-25 6:22 ` bug#3372: 23.0.94; Wrong input of umlauts in table mode Uwe Siart
2009-05-25 7:45 ` Kenichi Handa [this message]
2009-05-26 3:40 ` bug#3372: marked as done (23.0.94; Wrong input of umlauts in table mode) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1M8Url-0006ev-84@etlken \
--to=handa@m17n.org \
--cc=3372@emacsbugs.donarmstrong.com \
--cc=Takaaki.Ota@am.sony.com \
--cc=uwe.siart@tum.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.