From: Kenichi Handa <handa@m17n.org>
To: Jason Rumney <jasonr@gnu.org>
Cc: F.J.Wright@qmul.ac.uk, 3319@emacsbugs.donarmstrong.com
Subject: bug#3319: 23.0.93; Default font
Date: Tue, 19 May 2009 14:42:14 +0900 [thread overview]
Message-ID: <E1M6I5e-00041e-Ae@etlken> (raw)
In-Reply-To: <4A1227C1.2010503@gnu.org> (message from Jason Rumney on Tue, 19 May 2009 11:30:09 +0800)
In article <4A1227C1.2010503@gnu.org>, Jason Rumney <jasonr@gnu.org> writes:
> Kenichi Handa wrote:
> > I think what you intend by :family "outline-lucida sans
> > typewriter" is actually :foundry "outline" :family "lucida
> > sans typewriter", right. If so, I've just installed a fix.
> > Please try again.
> Please ensure your fix does not break cases like :family "MingLiU-ExtB",
> where the hyphen really is part of the family name.
We can't handle that kind of family name without breaking a
backward compatibility. We discussed this matter a while
ago, but didn't reach a conclusion. I'll put the last mail
on that thread at the tail.
Anyway, my change is just this.
- (setq foundry (match-string 2 family)))
- (setq family (match-string 1 family)))
+ (setq foundry (match-string 1 family)))
+ (setq family (match-string 2 family)))
and it is a fix of a bug introduced by this change.
2008-10-14 Chong Yidong <cyd@stupidchicken.com>
* faces.el (set-face-attribute): Set family and foundry before
other attributes.
---
Kenichi Handa
handa@m17n.org
------------------------------------------------------------
From: Kenichi Handa <handa@m17n.org>
To: Miles Bader <miles@gnu.org>
In-reply-to: <buo7icb1fnp.fsf@dhapc248.dev.necel.com> (message from Miles
Bader on Fri, 27 Jun 2008 16:49:14 +0900)
References: <87hcbi9vbg.fsf@catnip.gol.com>
<je1w2loom0.fsf@sykes.suse.de> <buohcbh6es9.fsf@dhapc248.dev.necel.com>
<4862198F.4060305@gnu.org> <E1KBTIl-0006en-Nc@etlken.m17n.org> <jwviqvxk4bq.fsf-monnier+emacs@gnu.org> <E1KC8Gs-0006kZ-PQ@etlken.m17n.org>
<buo7icb1fnp.fsf@dhapc248.dev.necel.com>
Content-Type: text/plain; charset=US-ASCII
Message-Id: <E1KC94K-0007dY-At@etlken.m17n.org>
Date: Fri, 27 Jun 2008 17:12:32 +0900
Cc: schwab@suse.de, jasonr@gnu.org, monnier@iro.umontreal.ca,
emacs-devel@gnu.org
Subject: Re: sans-serif name change
In article <buo7icb1fnp.fsf@dhapc248.dev.necel.com>, Miles Bader <miles.bader@necel.com> writes:
> Kenichi Handa <handa@m17n.org> writes:
> > And, fontconfig requires `-' in a family name to be escaped
> > by `\':
..
> > So, how about using the same rule for Emacs?
> >
> > (set-face-attribute 'variable-pitch nil :family "sans\\-serif")
> But currently other places, such as `set-frame-font' seem to work
> properly if passed "Sans-Serif" without escaping the "-". Perhaps some
> part of emacs is already adding the backslash?
No. In ftfont.c, these names:
"mono", "monospace", "sans-serif", "sans serif", "sans", "serif"
are specially recognized as generic family names. In
addition, fontconfig accepts the literal "sans-serif" when
used in the function FcPatternAddString (pat, FC_FAMILY, ...).
Fontconfig requires escaping only on parsing a font name,
and adds escaping on generating a font name.
> I think _if_ there are fonts with "-" in their name, requiring the dash
> to be escaped will annoy and confuse users, and lead to bug reports.
> I don't know how many such fonts there are, of course.
> [I'd say just get rid of the old-style foundry-family names; do we
> really care?]
As I wrote before, I tend to agree with breaking the
backward compatibility here.
---
Kenichi Handa
handa@ni.aist.go.jp
next prev parent reply other threads:[~2009-05-19 5:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <001801c9d71a$8bade240$a309a6c0$@J.Wright@qmul.ac.uk>
2009-05-19 1:30 ` bug#3319: 23.0.93; Default font Kenichi Handa
2009-05-19 3:30 ` Jason Rumney
2009-05-19 5:42 ` Kenichi Handa [this message]
2009-05-19 17:14 ` Francis Wright
[not found] ` <006601c9d8a5$563b2550$02b16ff0$@j.wright@qmul.ac.uk>
2009-05-20 0:40 ` Kenichi Handa
2009-05-20 16:57 ` Francis Wright
2009-05-19 14:33 ` Stefan Monnier
2009-05-19 17:03 ` Francis Wright
2009-05-20 0:28 ` Kenichi Handa
2009-05-20 2:16 ` Stefan Monnier
2009-05-20 4:14 ` Kenichi Handa
2009-05-20 17:02 ` Francis Wright
2009-05-25 16:34 ` Francis Wright
2009-05-17 18:08 Francis Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1M6I5e-00041e-Ae@etlken \
--to=handa@m17n.org \
--cc=3319@emacsbugs.donarmstrong.com \
--cc=F.J.Wright@qmul.ac.uk \
--cc=jasonr@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.