bug#3194: 23.0.93; Error opening X frame when it's named

bug#3194: 23.0.93; Error opening X frame when it's named

[Jose Antonio Ortega Ruiz]

1)  emacs -nw -Q
2) in *scratch*, evaluating
     (make-frame-on-display (gentenv "DISPLAY"))
   or
     (make-frame-on-display (gentenv "DISPLAY")
                            '((width . 80) (height . 10)))
   works fine
3) but, when including `name' as one of the frame parameters:
     (make-frame-on-display (gentenv "DISPLAY")
                            '((name . "foo")))
 one gets the following error:

Debugger entered--Lisp error: (error "X windows are not in use or not initialized")
  x-get-resource("geometry" "Geometry")
  x-handle-named-frame-geometry(((window-system . x) (display . ":0.0") (name . "foo") (width . 80) (height . 10)))
  x-create-frame-with-faces(((window-system . x) (display . ":0.0") (name . "foo") (width . 80) (height . 10)))
  make-frame(((window-system . x) (display . ":0.0") (name . "foo") (width . 80) (height . 10)))
  make-frame-on-display(":0.0" ((name . "foo") (width . 80) (height . 10)))
  eval((make-frame-on-display (getenv "DISPLAY") (quote (... ... ...))))
  eval-last-sexp-1(t)
  eval-last-sexp(t)
  eval-print-last-sexp()
  call-interactively(eval-print-last-sexp nil nil)

In GNU Emacs 23.0.93.1 (i486-pc-linux-gnu, GTK+ Version 2.16.1)
 of 2009-05-01 on elegiac, modified by Debian
 (emacs-snapshot package, version 1:20090501-1)
configured using `configure  '--build' 'i486-linux-gnu' '--host' 'i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/23.0.93/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.0.93/site-lisp:/usr/share/emacs/site-lisp' '--with-x=yes' '--with-x-toolkit=gtk' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2' 'LDFLAGS=-g -Wl,--as-needed' 'CPPFLAGS=''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Debugger

Minor modes in effect:
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
( m a k e - f r a m e - o n - d i s p l a y SPC ( g 
e t e n v SPC " D S DEL I S P L A Y " ) ) C-j <switch-frame> 
C-x 5 0 C-p C-p C-f C-f C-f C-f C-f C-f C-f C-f C-f 
C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f 
C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f 
C-f C-f C-f C-f C-f C-f C-j C-p C-k TAB ' ( ( w i t 
h DEL DEL d t h SPC . SPC 8 0 ) SPC ( h e i g h t . 
DEL SPC . 1 DEL SPC 1 0 ) ) ) C-n C-a C-k C-p C-e DEL 
) C-j <switch-frame> C-x 5 0 C-l C-p C-k C-k C-k C-k 
C-k C-p C-e C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b 
C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b 
C-b C-b C-b C-b C-b ( n a m e SPC . SPC " f o o " SPC 
) SPC C-e C-j C-p C-@ C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-n ESC w ESC x r e p o r t - b u TAB RET

Recent messages:
("emacs" "-Q")
For information about GNU Emacs and the GNU system, type C-h C-a.
Entering debugger...
Mark set

bug#3194: marked as done (23.0.93; Error opening X frame when it's named)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 884 bytes --]


Your message dated Sat, 27 Jun 2009 16:45:31 -0400
with message-id <87ws6x76dw.fsf@stupidchicken.com>
and subject line Re: 23.0.93; Error opening X frame when it's named
has caused the Emacs bug report #3194,
regarding 23.0.93; Error opening X frame when it's named
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
3194: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=3194
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 6595 bytes --]

From: Jose Antonio Ortega Ruiz <jaortega@gmail.com>
To: emacs-pretest-bug@gnu.org
Cc: rfrancoise@debian.org
Subject: 23.0.93; Error opening X frame when it's named
Date: Sat, 02 May 2009 21:09:44 +0200
Message-ID: <E1M0Kam-0004JC-OD@mithrandir.homeunix.net>


1)  emacs -nw -Q
2) in *scratch*, evaluating
     (make-frame-on-display (gentenv "DISPLAY"))
   or
     (make-frame-on-display (gentenv "DISPLAY")
                            '((width . 80) (height . 10)))
   works fine
3) but, when including `name' as one of the frame parameters:
     (make-frame-on-display (gentenv "DISPLAY")
                            '((name . "foo")))
 one gets the following error:

Debugger entered--Lisp error: (error "X windows are not in use or not initialized")
  x-get-resource("geometry" "Geometry")
  x-handle-named-frame-geometry(((window-system . x) (display . ":0.0") (name . "foo") (width . 80) (height . 10)))
  x-create-frame-with-faces(((window-system . x) (display . ":0.0") (name . "foo") (width . 80) (height . 10)))
  make-frame(((window-system . x) (display . ":0.0") (name . "foo") (width . 80) (height . 10)))
  make-frame-on-display(":0.0" ((name . "foo") (width . 80) (height . 10)))
  eval((make-frame-on-display (getenv "DISPLAY") (quote (... ... ...))))
  eval-last-sexp-1(t)
  eval-last-sexp(t)
  eval-print-last-sexp()
  call-interactively(eval-print-last-sexp nil nil)

In GNU Emacs 23.0.93.1 (i486-pc-linux-gnu, GTK+ Version 2.16.1)
 of 2009-05-01 on elegiac, modified by Debian
 (emacs-snapshot package, version 1:20090501-1)
configured using `configure  '--build' 'i486-linux-gnu' '--host' 'i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/23.0.93/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.0.93/site-lisp:/usr/share/emacs/site-lisp' '--with-x=yes' '--with-x-toolkit=gtk' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2' 'LDFLAGS=-g -Wl,--as-needed' 'CPPFLAGS=''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Debugger

Minor modes in effect:
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
( m a k e - f r a m e - o n - d i s p l a y SPC ( g 
e t e n v SPC " D S DEL I S P L A Y " ) ) C-j <switch-frame> 
C-x 5 0 C-p C-p C-f C-f C-f C-f C-f C-f C-f C-f C-f 
C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f 
C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f 
C-f C-f C-f C-f C-f C-f C-j C-p C-k TAB ' ( ( w i t 
h DEL DEL d t h SPC . SPC 8 0 ) SPC ( h e i g h t . 
DEL SPC . 1 DEL SPC 1 0 ) ) ) C-n C-a C-k C-p C-e DEL 
) C-j <switch-frame> C-x 5 0 C-l C-p C-k C-k C-k C-k 
C-k C-p C-e C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b 
C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b 
C-b C-b C-b C-b C-b ( n a m e SPC . SPC " f o o " SPC 
) SPC C-e C-j C-p C-@ C-n C-n C-n C-n C-n C-n C-n C-n 
C-n C-n C-n ESC w ESC x r e p o r t - b u TAB RET

Recent messages:
("emacs" "-Q")
For information about GNU Emacs and the GNU system, type C-h C-a.
Entering debugger...
Mark set



[-- Attachment #3: Type: message/rfc822, Size: 2027 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: Jose Antonio Ortega Ruiz <jaortega@gmail.com>
Cc: rfrancoise@debian.org, 3194-done@emacsbugs.donarmstrong.com
Subject: Re: 23.0.93; Error opening X frame when it's named
Date: Sat, 27 Jun 2009 16:45:31 -0400
Message-ID: <87ws6x76dw.fsf@stupidchicken.com>

> x-handle-named-frame-geometry really ought to open the X connection.
> The reason this does not happen for the first X frame is that we
> detect that specially, and open the X connection for initializing the
> various graphical settings.
>
> I don't want to make any changes to the logic at this stage of the
> pretest, so I've installed a temporary workaround, which ignores the
> error in x-handle-named-frame-geometry.

I have now checked a proper fix for this into the CVS trunk (which will
eventually lead into Emacs 23.2).

Thanks for the bug report.

bug#3194: 23.0.93; Error opening X frame when it's named

[Chong Yidong]

> 1) emacs -nw -Q
> 3) (make-frame-on-display (getenv "DISPLAY")
>                             '((name . "foo")))
>
> one gets the following error:
>   x-get-resource("geometry" "Geometry")
>   ...
>   call-interactively(eval-print-last-sexp nil nil)
>
> In GNU Emacs 23.0.93.1 (i486-pc-linux-gnu, GTK+ Version 2.16.1)
>  of 2009-05-01 on elegiac, modified by Debian
>  (emacs-snapshot package, version 1:20090501-1)

I can't reproduce this with latest CVS, nor with the 23.0.93 pretest.
The frame is opened with the correct name, and no errors.

Romaine, are any of the Debian modifications relevant here?

bug#3194: 23.0.93; Error opening X frame when it's named

[Jose Antonio Ortega Ruiz]

Chong Yidong <cyd@stupidchicken.com> writes:

>> 1) emacs -nw -Q
>> 3) (make-frame-on-display (getenv "DISPLAY")
>>                             '((name . "foo")))
>>
>> one gets the following error:
>>   x-get-resource("geometry" "Geometry")
>>   ...
>>   call-interactively(eval-print-last-sexp nil nil)
>>
>> In GNU Emacs 23.0.93.1 (i486-pc-linux-gnu, GTK+ Version 2.16.1)
>>  of 2009-05-01 on elegiac, modified by Debian
>>  (emacs-snapshot package, version 1:20090501-1)
>
> I can't reproduce this with latest CVS, nor with the 23.0.93 pretest.
> The frame is opened with the correct name, and no errors.
>

The *first* time I try, it works; but subsequent re-evaluations (after
closing the initial frame), fail with the error i reported. Could this
be your case too?

Thanks!
jao

bug#3194: 23.0.93; Error opening X frame when it's named

[Chong Yidong]

Jose Antonio Ortega Ruiz <jaortega@gmail.com> writes:

> The *first* time I try, it works; but subsequent re-evaluations (after
> closing the initial frame), fail with the error i reported. Could this
> be your case too?

OK, I see the problem.  This is a loophole in the frame creating
logic---we usually rely on x-create-frame to open the X connection if
it's not already open, but for named faces we need the X resources
associated with the face name.  So x-handle-named-frame-geometry really
ought to open the X connection.  The reason this does not happen for the
first X frame is that we detect that specially, and open the X
connection for initializing the various graphical settings.

I don't want to make any changes to the logic at this stage of the
pretest, so I've installed a temporary workaround, which ignores the
error in x-handle-named-frame-geometry.  This has one drawback: any
special X resources you associate with that frame name are not
recognized.

I'll keep this bug open, and look into a more comprehensive solution
after the release.