From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard M Stallman Newsgroups: gmane.emacs.bugs Subject: bug#2941: rmail's new handling of Babyl files is odd Date: Fri, 10 Apr 2009 10:26:33 -0400 Message-ID: References: Reply-To: rms@gnu.org, 2941@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: ger.gmane.org 1239374668 12741 80.91.229.12 (10 Apr 2009 14:44:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 10 Apr 2009 14:44:28 +0000 (UTC) Cc: bug-gnu-emacs@gnu.org To: Glenn Morris , 2941@emacsbugs.donarmstrong.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 10 16:45:46 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LsHzA-0005i5-3q for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Apr 2009 16:45:40 +0200 Original-Received: from localhost ([127.0.0.1]:47753 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LsHxl-00019k-Lt for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Apr 2009 10:44:13 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LsHxW-000116-5O for bug-gnu-emacs@gnu.org; Fri, 10 Apr 2009 10:43:58 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LsHxQ-0000w5-W9 for bug-gnu-emacs@gnu.org; Fri, 10 Apr 2009 10:43:57 -0400 Original-Received: from [199.232.76.173] (port=37711 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LsHxQ-0000vq-S3 for bug-gnu-emacs@gnu.org; Fri, 10 Apr 2009 10:43:52 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:50289) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LsHxP-0001Qg-R7 for bug-gnu-emacs@gnu.org; Fri, 10 Apr 2009 10:43:52 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n3AEhn6d029905; Fri, 10 Apr 2009 07:43:50 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n3AEZ3MV026972; Fri, 10 Apr 2009 07:35:03 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Richard M Stallman Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Fri, 10 Apr 2009 14:35:03 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2941 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.123937360325218 (code B ref -1); Fri, 10 Apr 2009 14:35:03 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 10 Apr 2009 14:26:43 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n3AEQdMp025206 for ; Fri, 10 Apr 2009 07:26:41 -0700 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LsHgl-0001zx-IK for bug-gnu-emacs@gnu.org; Fri, 10 Apr 2009 10:26:39 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LsHgg-0001xC-VV for bug-gnu-emacs@gnu.org; Fri, 10 Apr 2009 10:26:39 -0400 Original-Received: from [199.232.76.173] (port=43004 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LsHgg-0001wV-E5 for bug-gnu-emacs@gnu.org; Fri, 10 Apr 2009 10:26:34 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:48204) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LsHgf-0007Qf-UC for bug-gnu-emacs@gnu.org; Fri, 10 Apr 2009 10:26:34 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1LsHgf-0003rp-G1; Fri, 10 Apr 2009 10:26:33 -0400 In-reply-to: (message from Glenn Morris on Thu, 09 Apr 2009 15:48:12 -0400) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Fri, 10 Apr 2009 10:43:57 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:27059 Archived-At: Now if I press "s" to save the buffer, it is saved without warning, clobbering the existing Babyl file. I was expecting a confirmation prompt. There is no way to ask for confirmation when saving a file. (Look at basic-save-buffer.) Therefore I made it ask for confirmation when you make a "major" change, that would imply changing formats later if you save the results. Each kind of change can be treated as major or minor. Editing the message should be major; I overlooked that one. Please try the patch below. I decided to treat changes in labels as minor, because showing a message clears the "unseen" attribute. Treating that as major implies querying hen it shows an unseen message, which is typically just after visiting the file. It would be possible to treat changes in "unseen" as minor and changes in "deleted" as major, etc. *** rmailedit.el.~1.57.~ 2009-03-14 14:26:33.000000000 -0400 --- rmailedit.el 2009-04-10 06:35:10.000000000 -0400 *************** *** 117,122 **** --- 117,123 ---- (defun rmail-cease-edit () "Finish editing message; switch back to Rmail proper." (interactive) + (rmail-change-format) (if (rmail-summary-exists) (with-current-buffer rmail-summary-buffer (rmail-summary-enable)))