From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.devel Subject: Re: Printing Date: Mon, 06 Apr 2009 20:47:28 +0900 Message-ID: References: <5f0660120903280331y780c80b7i57a8115dc4b029eb@mail.gmail.com> <49CE3A84.9070705@swipnet.se> NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1239018417 32766 80.91.229.12 (6 Apr 2009 11:46:57 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 6 Apr 2009 11:46:57 +0000 (UTC) Cc: emacs-devel@gnu.org To: YAMAMOTO Mitsuharu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 06 13:48:14 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LqnJD-0006rj-UG for ged-emacs-devel@m.gmane.org; Mon, 06 Apr 2009 13:48:12 +0200 Original-Received: from localhost ([127.0.0.1]:56229 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LqnHp-0004LX-NH for ged-emacs-devel@m.gmane.org; Mon, 06 Apr 2009 07:46:45 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LqnHj-0004LM-Vc for emacs-devel@gnu.org; Mon, 06 Apr 2009 07:46:40 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LqnHf-0004L4-GZ for emacs-devel@gnu.org; Mon, 06 Apr 2009 07:46:39 -0400 Original-Received: from [199.232.76.173] (port=50301 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LqnHf-0004Ku-8w for emacs-devel@gnu.org; Mon, 06 Apr 2009 07:46:35 -0400 Original-Received: from mx1.aist.go.jp ([150.29.246.133]:50199) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LqnHe-0000i7-Il for emacs-devel@gnu.org; Mon, 06 Apr 2009 07:46:35 -0400 Original-Received: from rqsmtp1.aist.go.jp (rqsmtp1.aist.go.jp [150.29.254.115]) by mx1.aist.go.jp with ESMTP id n36BkVH0015492; Mon, 6 Apr 2009 20:46:31 +0900 (JST) env-from (handa@m17n.org) Original-Received: from smtp1.aist.go.jp by rqsmtp1.aist.go.jp with ESMTP id n36BkVD8024558; Mon, 6 Apr 2009 20:46:31 +0900 (JST) env-from (handa@m17n.org) Original-Received: by smtp1.aist.go.jp with ESMTP id n36BkTQI004586; Mon, 6 Apr 2009 20:46:29 +0900 (JST) env-from (handa@m17n.org) Original-Received: from handa by etlken with local (Exim 4.69) (envelope-from ) id 1LqnIW-000228-RS; Mon, 06 Apr 2009 20:47:28 +0900 In-reply-to: (message from YAMAMOTO Mitsuharu on Mon, 06 Apr 2009 17:45:01 +0900) X-detected-operating-system: by monty-python.gnu.org: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:110091 Archived-At: In article , YAMAMOTO Mitsuharu writes: > Not in the patch, but I can find a similar code in xftfont.c for the > latter. And maybe > XFillRectangle (FRAME_X_DISPLAY (f), FRAME_X_WINDOW (f), gc, > x, y - font->ascent, width, y + font->descent); > in ftxfont_draw_backgrond (sic) should be > XFillRectangle (FRAME_X_DISPLAY (f), FRAME_X_WINDOW (f), gc, > x, y - FONT_BASE (font), width, FONT_HEIGHT (font)); Thank you. I've just fixed them. > What do you think about the use of GC extension data in the patch? It > allows us to extract information about clipping rectangles not from > struct glyph_string but from GC without using a wrapper. Sorry but I don't have a time to read your code in detail. Could you explain why using GC extension data is better than (struct glyphs_string *)->clip? --- Kenichi Handa handa@m17n.org