From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard M Stallman Newsgroups: gmane.emacs.bugs,gmane.emacs.pretest.bugs Subject: bug#2445: 23.0.90; file name completion GCs a lot Date: Thu, 19 Mar 2009 15:37:00 -0400 Message-ID: References: Reply-To: rms@gnu.org, 2445@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: ger.gmane.org 1237493087 32014 80.91.229.12 (19 Mar 2009 20:04:47 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 19 Mar 2009 20:04:47 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org, 2445@emacsbugs.donarmstrong.com To: Stefan Monnier , 2445@emacsbugs.donarmstrong.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 19 21:06:00 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LkOUp-0000hF-8r for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Mar 2009 21:05:50 +0100 Original-Received: from localhost ([127.0.0.1]:48113 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LkOTS-0008MX-T3 for geb-bug-gnu-emacs@m.gmane.org; Thu, 19 Mar 2009 16:04:18 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LkOT4-0008BZ-Tt for bug-gnu-emacs@gnu.org; Thu, 19 Mar 2009 16:03:54 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LkOSy-00089p-Lh for bug-gnu-emacs@gnu.org; Thu, 19 Mar 2009 16:03:54 -0400 Original-Received: from [199.232.76.173] (port=42876 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LkOSx-00089Y-VF for bug-gnu-emacs@gnu.org; Thu, 19 Mar 2009 16:03:48 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:53285) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LkOSw-00014k-6z for bug-gnu-emacs@gnu.org; Thu, 19 Mar 2009 16:03:46 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2JK3hBU001006; Thu, 19 Mar 2009 13:03:44 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n2JJj3cI028277; Thu, 19 Mar 2009 12:45:03 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Richard M Stallman Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 19 Mar 2009 19:45:03 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2445 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.123749143026753 (code B ref -1); Thu, 19 Mar 2009 19:45:03 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 19 Mar 2009 19:37:10 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2JJb1h8026742; Thu, 19 Mar 2009 12:37:02 -0700 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1LkO32-0004Ia-90; Thu, 19 Mar 2009 15:37:00 -0400 In-reply-to: (message from Stefan Monnier on Tue, 17 Mar 2009 14:03:38 -0400) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Thu, 19 Mar 2009 16:03:54 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:26490 gmane.emacs.pretest.bugs:24158 Archived-At: Can you try the patch below to confirm it fixes your problem? The problem in my real cases is fixed given the sources as of yesterday. It looks like you've identified fixes to other big slowdowns that arise in yet larger test cases. I don't need them, but now that you've written them, you may as well install them unless they will cause trouble for someone. In the case of file completion, a simple (file-directory-p "xmail/") would give us the necessary answer, but the code is generic and the only/best way to get this information from a completion tables is to call (try-completion "xmail/" table), which calls (file-name-completion "" "xmail/"). I have a feeling that (file-name-completion "" "xmail/") ought to first check (file-directory-p "xmail/") and return t if that does. In other words, if the buffer contains a valid directory name, completion should treat that as fixed. It should only try to do completion on previous file name components when they don't match existing names.