From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs/src fontset.c Date: Fri, 13 Mar 2009 14:29:37 +0900 Message-ID: References: <87eix49ppl.fsf@cyd.mit.edu> <49B907DF.8080004@gnu.org> NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1236922200 913 80.91.229.12 (13 Mar 2009 05:30:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 13 Mar 2009 05:30:00 +0000 (UTC) Cc: lekktu@gmail.com, cyd@stupidchicken.com, unicad.el@gmail.com, emacs-devel@gnu.org To: Jason Rumney Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 13 06:31:16 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LhzzH-0008SP-KM for ged-emacs-devel@m.gmane.org; Fri, 13 Mar 2009 06:31:15 +0100 Original-Received: from localhost ([127.0.0.1]:43097 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lhzxv-000330-E6 for ged-emacs-devel@m.gmane.org; Fri, 13 Mar 2009 01:29:51 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lhzxo-00032v-0l for emacs-devel@gnu.org; Fri, 13 Mar 2009 01:29:44 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lhzxi-00032h-GT for emacs-devel@gnu.org; Fri, 13 Mar 2009 01:29:42 -0400 Original-Received: from [199.232.76.173] (port=33517 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lhzxi-00032e-7p for emacs-devel@gnu.org; Fri, 13 Mar 2009 01:29:38 -0400 Original-Received: from mx1.aist.go.jp ([150.29.246.133]:54729) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lhzxg-00075v-QD; Fri, 13 Mar 2009 01:29:37 -0400 Original-Received: from rqsmtp1.aist.go.jp (rqsmtp1.aist.go.jp [150.29.254.115]) by mx1.aist.go.jp with ESMTP id n2D5TPKU005472; Fri, 13 Mar 2009 14:29:25 +0900 (JST) env-from (handa@m17n.org) Original-Received: from smtp1.aist.go.jp by rqsmtp1.aist.go.jp with ESMTP id n2D5TPGW028121; Fri, 13 Mar 2009 14:29:25 +0900 (JST) env-from (handa@m17n.org) Original-Received: by smtp1.aist.go.jp with ESMTP id n2D5TOie004223; Fri, 13 Mar 2009 14:29:24 +0900 (JST) env-from (handa@m17n.org) Original-Received: from handa by etlken with local (Exim 4.69) (envelope-from ) id 1Lhzxh-0004NQ-HY; Fri, 13 Mar 2009 14:29:37 +0900 In-reply-to: <49B907DF.8080004@gnu.org> (message from Jason Rumney on Thu, 12 Mar 2009 21:02:23 +0800) X-detected-operating-system: by monty-python.gnu.org: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:109600 Archived-At: In article <49B907DF.8080004@gnu.org>, Jason Rumney writes: > Kenichi Handa wrote: > > By the way, after the following change, (frame-parameter nil > > 'font) doesn't return a fontset of the current frame. > > > > 2009-01-14 Jason Rumney > > > > * frame.c (x_set_font): Always store a font to the font parameter, > > never a fontset. (Bug#1562) > > > > Now the right way to get a fontset is: > > (face-attribute 'default :fontset) > > > Perhaps (frame-parameter nil 'fontset) could be made to work also. But then, don't we have to think about the semantics of this? (modify-frame-parameters nil '((fontset . ...))) > I made that change because it seemed the most obvious way > to fix Bug#1562, I see. > and since we have both FRAME_FONTSET (f) > and FRAME_FONT (f), which in the previous code both > returned fontsets under some circumstances. It seemed > cleaner to have FRAME_FONTSET always return a fontset, and > FRAME_FONT always return a font. ??? If there's a case that FRAME_FONT (f) returns a fontset, it's a bug. In what circumstances, does it happen? --- Kenichi Handa handa@m17n.org