* Re: [Emacs-diffs] emacs/src fontset.c
[not found] <E1LhJDy-00082t-Cg@cvs.savannah.gnu.org>
@ 2009-03-11 10:59 ` Juanma Barranquero
2009-03-11 12:31 ` Miles Bader
2009-03-11 12:44 ` Kenichi Handa
0 siblings, 2 replies; 7+ messages in thread
From: Juanma Barranquero @ 2009-03-11 10:59 UTC (permalink / raw
To: Kenichi Handa; +Cc: Emacs developers
On Wed, Mar 11, 2009 at 08:51, Kenichi Handa <handa@m17n.org> wrote:
> + font_object = font_open_by_spec (f, font_spec);
oo-spd/i386/temacs1.a(fontset.o): In function `Fset_fontset_font':
C:\emacs\src/fontset.c:1603: undefined reference to `font_open_by_spec'
Juanma
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Emacs-diffs] emacs/src fontset.c
2009-03-11 10:59 ` [Emacs-diffs] emacs/src fontset.c Juanma Barranquero
@ 2009-03-11 12:31 ` Miles Bader
2009-03-11 12:44 ` Kenichi Handa
1 sibling, 0 replies; 7+ messages in thread
From: Miles Bader @ 2009-03-11 12:31 UTC (permalink / raw
To: emacs-devel
Juanma Barranquero <lekktu@gmail.com> writes:
> On Wed, Mar 11, 2009 at 08:51, Kenichi Handa <handa@m17n.org> wrote:
>
>> + font_object = font_open_by_spec (f, font_spec);
>
> oo-spd/i386/temacs1.a(fontset.o): In function `Fset_fontset_font':
> C:\emacs\src/fontset.c:1603: undefined reference to `font_open_by_spec'
Yup, me too, on debian (with the latest libraries available in unstable installed).
-Miles
--
"Nah, there's no bigger atheist than me. Well, I take that back.
I'm a cancer screening away from going agnostic and a biopsy away
from full-fledged Christian." [Adam Carolla]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Emacs-diffs] emacs/src fontset.c
2009-03-11 10:59 ` [Emacs-diffs] emacs/src fontset.c Juanma Barranquero
2009-03-11 12:31 ` Miles Bader
@ 2009-03-11 12:44 ` Kenichi Handa
2009-03-11 13:03 ` Chong Yidong
1 sibling, 1 reply; 7+ messages in thread
From: Kenichi Handa @ 2009-03-11 12:44 UTC (permalink / raw
To: Juanma Barranquero; +Cc: emacs-devel
In article <f7ccd24b0903110359o17d20ec1p1a7e6b60474c1c98@mail.gmail.com>, Juanma Barranquero <lekktu@gmail.com> writes:
> On Wed, Mar 11, 2009 at 08:51, Kenichi Handa <handa@m17n.org> wrote:
> > + font_object = font_open_by_spec (f, font_spec);
> oo-spd/i386/temacs1.a(fontset.o): In function `Fset_fontset_font':
> C:\emacs\src/fontset.c:1603: undefined reference to `font_open_by_spec'
Please try again. I committed all changes.
---
Kenichi Handa
handa@m17n.org
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Emacs-diffs] emacs/src fontset.c
2009-03-11 12:44 ` Kenichi Handa
@ 2009-03-11 13:03 ` Chong Yidong
2009-03-12 0:41 ` Kenichi Handa
0 siblings, 1 reply; 7+ messages in thread
From: Chong Yidong @ 2009-03-11 13:03 UTC (permalink / raw
To: Kenichi Handa; +Cc: Juanma Barranquero, emacs-devel
Kenichi Handa <handa@m17n.org> writes:
> Please try again. I committed all changes.
What is the purpose of these latest changes?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Emacs-diffs] emacs/src fontset.c
2009-03-11 13:03 ` Chong Yidong
@ 2009-03-12 0:41 ` Kenichi Handa
2009-03-12 13:02 ` Jason Rumney
0 siblings, 1 reply; 7+ messages in thread
From: Kenichi Handa @ 2009-03-12 0:41 UTC (permalink / raw
To: Chong Yidong; +Cc: lekktu, unicad.el, emacs-devel
In article <87eix49ppl.fsf@cyd.mit.edu>, Chong Yidong <cyd@stupidchicken.com> writes:
> Kenichi Handa <handa@m17n.org> writes:
> > Please try again. I committed all changes.
> What is the purpose of these latest changes?
To fix this problem reported a while ago:
In article <760897560812160136v32810859x92081fde365dee1e@mail.gmail.com>, "Qichen Huang" <unicad.el@gmail.com> writes:
> run emacs without any extra settings: runemacs.exe -Q
> (set-fontset-font
> "fontset-startup" 'ascii ;; or 'latin
> "-*-Courier New-*-*-*-*-17-*-*-*-*-*-iso8859-1")
> or
> (set-fontset-font (frame-parameter nil 'font)
> 'ascii ;; or 'latin
> (font-spec :family "Courier New" :size 17))
> Neither work.
In the new code, when a font for ASCII is changed in a
fontset, the default font is changed to that new font in all
frames that are using the same fontset.
By the way, after the following change, (frame-parameter nil
'font) doesn't return a fontset of the current frame.
2009-01-14 Jason Rumney <jasonr@gnu.org>
* frame.c (x_set_font): Always store a font to the font parameter,
never a fontset. (Bug#1562)
Now the right way to get a fontset is:
(face-attribute 'default :fontset)
---
Kenichi Handa
handa@m17n.org
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Emacs-diffs] emacs/src fontset.c
2009-03-12 0:41 ` Kenichi Handa
@ 2009-03-12 13:02 ` Jason Rumney
2009-03-13 5:29 ` Kenichi Handa
0 siblings, 1 reply; 7+ messages in thread
From: Jason Rumney @ 2009-03-12 13:02 UTC (permalink / raw
To: Kenichi Handa; +Cc: lekktu, Chong Yidong, unicad.el, emacs-devel
Kenichi Handa wrote:
> By the way, after the following change, (frame-parameter nil
> 'font) doesn't return a fontset of the current frame.
>
> 2009-01-14 Jason Rumney <jasonr@gnu.org>
>
> * frame.c (x_set_font): Always store a font to the font parameter,
> never a fontset. (Bug#1562)
>
> Now the right way to get a fontset is:
> (face-attribute 'default :fontset)
>
Perhaps (frame-parameter nil 'fontset) could be made to work also. I
made that change because it seemed the most obvious way to fix Bug#1562,
and since we have both FRAME_FONTSET (f) and FRAME_FONT (f), which in
the previous code both returned fontsets under some circumstances. It
seemed cleaner to have FRAME_FONTSET always return a fontset, and
FRAME_FONT always return a font.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Emacs-diffs] emacs/src fontset.c
2009-03-12 13:02 ` Jason Rumney
@ 2009-03-13 5:29 ` Kenichi Handa
0 siblings, 0 replies; 7+ messages in thread
From: Kenichi Handa @ 2009-03-13 5:29 UTC (permalink / raw
To: Jason Rumney; +Cc: lekktu, cyd, unicad.el, emacs-devel
In article <49B907DF.8080004@gnu.org>, Jason Rumney <jasonr@gnu.org> writes:
> Kenichi Handa wrote:
> > By the way, after the following change, (frame-parameter nil
> > 'font) doesn't return a fontset of the current frame.
> >
> > 2009-01-14 Jason Rumney <jasonr@gnu.org>
> >
> > * frame.c (x_set_font): Always store a font to the font parameter,
> > never a fontset. (Bug#1562)
> >
> > Now the right way to get a fontset is:
> > (face-attribute 'default :fontset)
> >
> Perhaps (frame-parameter nil 'fontset) could be made to work also.
But then, don't we have to think about the semantics of this?
(modify-frame-parameters nil '((fontset . ...)))
> I made that change because it seemed the most obvious way
> to fix Bug#1562,
I see.
> and since we have both FRAME_FONTSET (f)
> and FRAME_FONT (f), which in the previous code both
> returned fontsets under some circumstances. It seemed
> cleaner to have FRAME_FONTSET always return a fontset, and
> FRAME_FONT always return a font.
??? If there's a case that FRAME_FONT (f) returns a fontset,
it's a bug. In what circumstances, does it happen?
---
Kenichi Handa
handa@m17n.org
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2009-03-13 5:29 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1LhJDy-00082t-Cg@cvs.savannah.gnu.org>
2009-03-11 10:59 ` [Emacs-diffs] emacs/src fontset.c Juanma Barranquero
2009-03-11 12:31 ` Miles Bader
2009-03-11 12:44 ` Kenichi Handa
2009-03-11 13:03 ` Chong Yidong
2009-03-12 0:41 ` Kenichi Handa
2009-03-12 13:02 ` Jason Rumney
2009-03-13 5:29 ` Kenichi Handa
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.