From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard M Stallman Newsgroups: gmane.emacs.bugs Subject: bug#2228: 23.0.90; rmail-cease-edit ignores changes to the message headers Date: Wed, 11 Feb 2009 01:22:50 -0500 Message-ID: References: Reply-To: rms@gnu.org, 2228@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: ger.gmane.org 1234334648 32725 80.91.229.12 (11 Feb 2009 06:44:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 11 Feb 2009 06:44:08 +0000 (UTC) Cc: 2228@emacsbugs.donarmstrong.com To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 11 07:45:19 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LX8qU-0000vG-EP for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Feb 2009 07:45:18 +0100 Original-Received: from localhost ([127.0.0.1]:46737 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LX8pA-0007pX-JY for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Feb 2009 01:43:56 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LX8ot-0007lf-2M for bug-gnu-emacs@gnu.org; Wed, 11 Feb 2009 01:43:39 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LX8or-0007kr-Cc for bug-gnu-emacs@gnu.org; Wed, 11 Feb 2009 01:43:38 -0500 Original-Received: from [199.232.76.173] (port=39753 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LX8or-0007ke-08 for bug-gnu-emacs@gnu.org; Wed, 11 Feb 2009 01:43:37 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:54436) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LX8oq-0002I3-0q for bug-gnu-emacs@gnu.org; Wed, 11 Feb 2009 01:43:36 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1B6hXtq020928; Tue, 10 Feb 2009 22:43:34 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n1B6U2EO016864; Tue, 10 Feb 2009 22:30:02 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Richard M Stallman Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs , Rmail Maintainers Resent-Date: Wed, 11 Feb 2009 06:30:02 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2228 X-Emacs-PR-Package: emacs,rmail X-Emacs-PR-Keywords: Original-Received: via spool by 2228-submit@emacsbugs.donarmstrong.com id=B2228.123433349015452 (code B ref 2228); Wed, 11 Feb 2009 06:30:02 +0000 Original-Received: (at 2228) by emacsbugs.donarmstrong.com; 11 Feb 2009 06:24:50 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1B6OlLI015443 for <2228@emacsbugs.donarmstrong.com>; Tue, 10 Feb 2009 22:24:49 -0800 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1LX8Uk-0005hc-GK; Wed, 11 Feb 2009 01:22:50 -0500 In-reply-to: (message from Glenn Morris on Mon, 09 Feb 2009 22:38:30 -0500) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Wed, 11 Feb 2009 01:43:38 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:25158 Archived-At: > As it is now, you get the choice. If you display the full headers and > then edit, then you get to edit the full headers. With the minor drawback that it doesn't actually work, hence this bug report. It works fine for the usual job, editing the message body. Making it work for editing headers probably takes 200 lines of code. rmailedit as a whole seems overly complex to me. If I were doing it, I'd copy the expanded message text to a new buffer for editing, rather than re-using the rmail buffer. Aborting an edit would just kill the buffer. Saving an edit would compare the buffer text with the region between msgbeg and msgend in rmail-view-buffer, and swap it in if it differed, then call rmail-show-message. I would not object to switching to that approach, but still it shouldn't normally show all the unpruned headers.