From: Richard M Stallman <rms@gnu.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 2137@emacsbugs.donarmstrong.com
Subject: bug#2137: 23.0.60; Saving Rmail buffer does not show the "Saving file ..." message
Date: Wed, 04 Feb 2009 13:27:49 -0500 [thread overview]
Message-ID: <E1LUmTV-0000Gb-QB@fencepost.gnu.org> (raw)
In-Reply-To: <jwvprhzp5zu.fsf-monnier+emacsbugreports@gnu.org> (message from Stefan Monnier on Tue, 03 Feb 2009 16:26:21 -0500)
> IMO, using annotations for the job of saving the mailbox is also a
> horrible kludge. All that just to avoid defining an Rmail-specific
> binding for C-x C-s ...
Thanks for your support,
An Rmail-specific binding for C-x C-s is not enough to make saving
work correctly. Users can save the file through C-x s also, and other
commands too. The common mechanism for these commands is
`save-buffer'; whatever makes them save the right text has to work
inside there.
Eli wrote:
we could add to
rmail-write-region-annotate another hack: a call to buffer-size
followed by the same message "Saving file ..." that should have been
displayed by save-buffer.
The difficulty here is to display that message only in the case
where the hook was ultimately called from `save-buffer'. This could
be done by making `save-buffer' bind some variable for such hooks
to check.
However, such fixes are less clean that implementing `buffer-swapped-with'
and checking it in the necessary places. I previously implemented it in
`basic-save-buffer', but just moving the implementation to `save-buffer'
would make it DTRT for this. The fix would add no complexity.
The simplest fix is to simply always output the message rather than only
for files larger than 50KB.
That would be easy, but not quite the most convenient behavior.
The more difficult one is to move the message from save-buffer to
write-region.
next prev parent reply other threads:[~2009-02-04 18:27 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ud4dutuhg.fsf@gnu.org>
2009-01-31 19:13 ` bug#2137: 23.0.60; Saving Rmail buffer does not show the "Saving file ..." message Eli Zaretskii
2009-02-01 22:48 ` Richard M Stallman
2009-02-02 1:35 ` Stefan Monnier
2009-02-02 1:35 ` Stefan Monnier
2009-02-02 21:05 ` Eli Zaretskii
2009-02-03 4:12 ` Glenn Morris
2009-02-03 19:31 ` Eli Zaretskii
2009-02-03 21:26 ` Stefan Monnier
2009-02-04 4:23 ` Eli Zaretskii
2009-02-04 18:29 ` Eli Zaretskii
2009-02-04 18:27 ` Richard M Stallman [this message]
2009-02-04 19:49 ` Stefan Monnier
2009-02-04 20:14 ` Eli Zaretskii
2009-02-04 23:21 ` Stefan Monnier
2009-02-05 16:39 ` Richard M Stallman
2009-02-04 20:12 ` Eli Zaretskii
2009-02-03 21:29 ` Stefan Monnier
2009-02-04 4:16 ` Eli Zaretskii
2009-02-04 4:16 ` Eli Zaretskii
2009-02-04 19:46 ` Stefan Monnier
2009-02-04 19:46 ` Stefan Monnier
2009-02-03 21:29 ` Stefan Monnier
2009-02-02 21:05 ` Eli Zaretskii
2009-02-03 9:59 ` Richard M Stallman
2009-02-03 9:59 ` Richard M Stallman
2009-02-03 19:39 ` Eli Zaretskii
2009-02-07 10:35 ` bug#2137: marked as done (23.0.60; Saving Rmail buffer does not show the "Saving file ..." message) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1LUmTV-0000Gb-QB@fencepost.gnu.org \
--to=rms@gnu.org \
--cc=2137@emacsbugs.donarmstrong.com \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.