From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.bugs Subject: bug#1900: 23.0.60; detect attached file coding system, make emacs crash. Date: Wed, 14 Jan 2009 21:53:44 +0900 Message-ID: References: <877i51fd95.fsf@redflag-linux.com> Reply-To: Kenichi Handa , 1900@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org X-Trace: ger.gmane.org 1231938468 10218 80.91.229.12 (14 Jan 2009 13:07:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 14 Jan 2009 13:07:48 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org, emacs-devel@gnu.org To: Wang Diancheng Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 14 14:09:00 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LN5UQ-0003ce-Ot for geb-bug-gnu-emacs@m.gmane.org; Wed, 14 Jan 2009 14:08:59 +0100 Original-Received: from localhost ([127.0.0.1]:39397 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LN5TA-0003r5-7r for geb-bug-gnu-emacs@m.gmane.org; Wed, 14 Jan 2009 08:07:40 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LN5PC-0001IL-4S for bug-gnu-emacs@gnu.org; Wed, 14 Jan 2009 08:03:34 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LN5P8-0001Fw-HS for bug-gnu-emacs@gnu.org; Wed, 14 Jan 2009 08:03:31 -0500 Original-Received: from [199.232.76.173] (port=41462 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LN5P7-0001F6-40 for bug-gnu-emacs@gnu.org; Wed, 14 Jan 2009 08:03:29 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:55375) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LN5P6-0004F4-FJ for bug-gnu-emacs@gnu.org; Wed, 14 Jan 2009 08:03:28 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0ED3QS0003340; Wed, 14 Jan 2009 05:03:26 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n0ED02SQ002153; Wed, 14 Jan 2009 05:00:02 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: Kenichi Handa Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 14 Jan 2009 13:00:02 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: report 1900 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.1231937642895 (code B ref -1); Wed, 14 Jan 2009 13:00:02 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 14 Jan 2009 12:54:02 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n0ECrwuA000889 for ; Wed, 14 Jan 2009 04:54:00 -0800 Original-Received: from mail.gnu.org ([199.232.76.166]:47592 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LN5Eb-0000OE-OS for emacs-pretest-bug@gnu.org; Wed, 14 Jan 2009 07:52:37 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LN5Fq-00033h-Dt for emacs-pretest-bug@gnu.org; Wed, 14 Jan 2009 07:53:54 -0500 Original-Received: from mx1.aist.go.jp ([150.29.246.133]:52716) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LN5Fp-000335-Mf; Wed, 14 Jan 2009 07:53:54 -0500 Original-Received: from rqsmtp2.aist.go.jp (rqsmtp2.aist.go.jp [150.29.254.123]) by mx1.aist.go.jp with ESMTP id n0ECriYt026634; Wed, 14 Jan 2009 21:53:44 +0900 (JST) env-from (handa@m17n.org) Original-Received: from smtp4.aist.go.jp by rqsmtp2.aist.go.jp with ESMTP id n0ECrixn003580; Wed, 14 Jan 2009 21:53:44 +0900 (JST) env-from (handa@m17n.org) Original-Received: by smtp4.aist.go.jp with ESMTP id n0ECri5E011922; Wed, 14 Jan 2009 21:53:44 +0900 (JST) env-from (handa@m17n.org) Original-Received: from handa by etlken.m17n.org with local (Exim 4.69) (envelope-from ) id 1LN5Fg-0000hJ-8L; Wed, 14 Jan 2009 21:53:44 +0900 In-reply-to: <877i51fd95.fsf@redflag-linux.com> (message from Wang Diancheng on Mon, 12 Jan 2009 10:51:18 +0800) X-detected-operating-system: by monty-python.gnu.org: Solaris 9 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Wed, 14 Jan 2009 08:03:31 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:24102 Archived-At: In article <877i51fd95.fsf@redflag-linux.com>, Wang Diancheng writes: > detect attached file coding system with following code, make emacs crash > (with-temp-buffer > (insert-file-contents "/home/dcwang/1.txt") > (detect-coding-region (point-min) (point-max) t)) Thank you for the bug report. I've just committed a fix. But, the above code doesn't work as you expect because insert-file-contents inserts already decoded text in a buffer. You should do something like this, and this is faster. (with-temp-buffer (let ((coding-system-for-read 'no-conversion)) (insert-file-contents "/home/dcwang/1.txt") (detect-coding-region (point-min) (point-max) t))) Chong Yidong writes: > Looks like detect_coding_utf_16 forgets to check for negative values of > ONE_MORE_BYTE. Yes. But... > Handa-san, could you check the following patch? > ONE_MORE_BYTE (c1); > ONE_MORE_BYTE (c2); > + > + if (c1 < 0 || c2 < 0) > + break; > + > if (! e[c1]) > { > e[c1] = 1; That's not enough. c1 and c2 must be checked here too: e[c1] = 1; o[c2] = 1; "Juanma Barranquero" writes: > Don't you need a test also before lines 1605-1606, where c1 and c2 are > used as array indexes? That's not necessary because if c1 and c2 are non-negative, it is assured that they are byte values; i.e. less than 256. --- Kenichi Handa handa@m17n.org