bug#1509: 23.0.60; recover-file

bug#1509: 23.0.60; recover-file

[Richard M Stallman]

It seems that M-x recover-file fails to make the buffer as modified.
So the user will tend not to save the file afterwards.



In GNU Emacs 23.0.60.9 (mipsel-unknown-linux-gnu, GTK+ Version 2.12.11)
 of 2008-12-05 on lemote-yeeloong
configured using `configure  'CFLAGS=-O0 -g -Wno-pointer-sign' 'mipsel-unknown-linux-gnu' 'build_alias=mipsel-unknown-linux-gnu' 'host_alias=mipsel-unknown-linux-gnu' 'target_alias=mipsel-unknown-linux-gnu''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Dired by name

Minor modes in effect:
  diff-auto-refine-mode: t
  gpm-mouse-mode: t
  tooltip-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t
  abbrev-mode: t

Recent input:
E n g l i s h SPC i s n DEL DEL n SPC t h a t SPC p 
a g e SPC i s SPC s o SPC b a d SPC t h a t SPC i t 
SPC w i l l SPC e m b a r r a s s ESC b ESC b ESC d 
w i l l C-e SPC y o u . C-a ( C-e ESC DEL ESC DEL ESC 
DEL i s SPC e m b a r r a s s i n g . RET I SPC w o 
n d e r SPC w h o SPC w r o t e SPC i t . ) C-x 1 DEL 
SPC SPC W a s SPC i t r SPC w r i t t e n ESC b C-b 
ESC [ 2 ~ DEL C-e SPC ESC b C-b s DEL t C-e b y SPC 
s o m e o n e SPC i n SPC C h i n a ? ) RET C-c C-c 
C-x C-f e n d o r TAB RET ESC x r e C-g C-x d ESC p 
* ESC b ESC b * RET C-p C-x b C-g C-@ C-n = RET C-x 
o C-v C-x b RET ESC x r e c o v e r SPC f i l e RET 
ESC p DEL C-a C-d RET y e s RET C-x 1 C-v ESC v C-x 
b C-h C-g C-x C-g C-x C-b C-x o C-n C-n f g C-x o 1 
\ DEL DEL C-x C-s C-x o g C-x C-g ESC x r e p o r t 
SPC e m a s DEL c s SPC b u g RET

Recent messages:
Mark set [2 times]
Auto-saving...done
Sending...
Wrote /home/rms/outgoing/out-21
Sending...done
endorsements.text has auto save data; consider M-x recover-this-file
Quit [2 times]
Mark set
Quit
Wrote /home/rms/endorsements.text

bug#1509: 23.0.60; recover-file

[Glenn Morris]

Richard M Stallman wrote:

> It seems that M-x recover-file fails to make the buffer as modified.

It works as it should if you remove epa-file-find-file-hook from
find-file-hook.

recover-file calls after-find-file which runs find-file-hook.

epa-file-find-file-hook marks any non-epa files as unmodified for some
reason.

bug#1509: 23.0.60; recover-file

[Daiki Ueno]

>>>>> In <cbprk1p04m.fsf@fencepost.gnu.org> 
>>>>>	Glenn Morris <rgm@gnu.org> wrote:
GM> > It seems that M-x recover-file fails to make the buffer as modified.

GM> It works as it should if you remove epa-file-find-file-hook from
GM> find-file-hook.

GM> recover-file calls after-find-file which runs find-file-hook.

Thanks for pointing out this.  I've just installed a fix, which adjusts
modtime in epa-file's insert-file-contents handler instead of
find-file-hook.

GM> epa-file-find-file-hook marks any non-epa files as unmodified for some
GM> reason.

Perhaps this is the appropriate bug report (preceded by "Finally,
buffer..."): http://article.gmane.org/gmane.emacs.gnus.general/64734

Regards,
-- 
Daiki Ueno

bug#1509: marked as done (23.0.60; recover-file)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 830 bytes --]


Your message dated Tue, 9 Dec 2008 21:20:44 -0500
with message-id <18751.10108.126866.184664@fencepost.gnu.org>
and subject line Re: bug#1509: 23.0.60; recover-file
has caused the Emacs bug report #1509,
regarding 23.0.60; recover-file
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
1509: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1509
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3246 bytes --]

From: Richard M Stallman <rms@gnu.org>
To: emacs-pretest-bug@gnu.org
Subject: 23.0.60; recover-file
Date: Sun, 07 Dec 2008 04:05:53 -0500
Message-ID: <E1L9FaL-0001bv-NS@fencepost.gnu.org>


It seems that M-x recover-file fails to make the buffer as modified.
So the user will tend not to save the file afterwards.



In GNU Emacs 23.0.60.9 (mipsel-unknown-linux-gnu, GTK+ Version 2.12.11)
 of 2008-12-05 on lemote-yeeloong
configured using `configure  'CFLAGS=-O0 -g -Wno-pointer-sign' 'mipsel-unknown-linux-gnu' 'build_alias=mipsel-unknown-linux-gnu' 'host_alias=mipsel-unknown-linux-gnu' 'target_alias=mipsel-unknown-linux-gnu''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

Major mode: Dired by name

Minor modes in effect:
  diff-auto-refine-mode: t
  gpm-mouse-mode: t
  tooltip-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t
  abbrev-mode: t

Recent input:
E n g l i s h SPC i s n DEL DEL n SPC t h a t SPC p 
a g e SPC i s SPC s o SPC b a d SPC t h a t SPC i t 
SPC w i l l SPC e m b a r r a s s ESC b ESC b ESC d 
w i l l C-e SPC y o u . C-a ( C-e ESC DEL ESC DEL ESC 
DEL i s SPC e m b a r r a s s i n g . RET I SPC w o 
n d e r SPC w h o SPC w r o t e SPC i t . ) C-x 1 DEL 
SPC SPC W a s SPC i t r SPC w r i t t e n ESC b C-b 
ESC [ 2 ~ DEL C-e SPC ESC b C-b s DEL t C-e b y SPC 
s o m e o n e SPC i n SPC C h i n a ? ) RET C-c C-c 
C-x C-f e n d o r TAB RET ESC x r e C-g C-x d ESC p 
* ESC b ESC b * RET C-p C-x b C-g C-@ C-n = RET C-x 
o C-v C-x b RET ESC x r e c o v e r SPC f i l e RET 
ESC p DEL C-a C-d RET y e s RET C-x 1 C-v ESC v C-x 
b C-h C-g C-x C-g C-x C-b C-x o C-n C-n f g C-x o 1 
\ DEL DEL C-x C-s C-x o g C-x C-g ESC x r e p o r t 
SPC e m a s DEL c s SPC b u g RET

Recent messages:
Mark set [2 times]
Auto-saving...done
Sending...
Wrote /home/rms/outgoing/out-21
Sending...done
endorsements.text has auto save data; consider M-x recover-this-file
Quit [2 times]
Mark set
Quit
Wrote /home/rms/endorsements.text



[-- Attachment #3: Type: message/rfc822, Size: 1508 bytes --]

From: Glenn Morris <rgm@gnu.org>
To: Daiki Ueno <ueno@unixuser.org>
Cc: Richard Stallman <rms@gnu.org>, 1509-done@emacsbugs.donarmstrong.com
Subject: Re: bug#1509: 23.0.60; recover-file
Date: Tue, 9 Dec 2008 21:20:44 -0500
Message-ID: <18751.10108.126866.184664@fencepost.gnu.org>


Works for me; thanks.