From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.devel Subject: Re: Recent CVS Emacs breaks color-themes Date: Sat, 04 Oct 2008 11:45:02 +0900 Message-ID: References: <87wsgq1bcd.fsf@anzu.internal.golden-gryphon.com> <48E6223D.4000605@gmx.at> <87ljx51yiv.fsf@anzu.internal.golden-gryphon.com> <48E64E88.4040305@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII X-Trace: ger.gmane.org 1223088332 28828 80.91.229.12 (4 Oct 2008 02:45:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 4 Oct 2008 02:45:32 +0000 (UTC) Cc: srivasta@ieee.org, emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 04 04:46:29 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KlxA4-0003ML-PI for ged-emacs-devel@m.gmane.org; Sat, 04 Oct 2008 04:46:29 +0200 Original-Received: from localhost ([127.0.0.1]:52908 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Klx91-0006FA-HM for ged-emacs-devel@m.gmane.org; Fri, 03 Oct 2008 22:45:23 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Klx8w-0006F5-Pg for emacs-devel@gnu.org; Fri, 03 Oct 2008 22:45:18 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Klx8u-0006Et-US for emacs-devel@gnu.org; Fri, 03 Oct 2008 22:45:17 -0400 Original-Received: from [199.232.76.173] (port=37000 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Klx8u-0006Eq-Oe for emacs-devel@gnu.org; Fri, 03 Oct 2008 22:45:16 -0400 Original-Received: from mx1.aist.go.jp ([150.29.246.133]:36601) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Klx8t-0007kd-Tc for emacs-devel@gnu.org; Fri, 03 Oct 2008 22:45:16 -0400 Original-Received: from rqsmtp1.aist.go.jp (rqsmtp1.aist.go.jp [150.29.254.115]) by mx1.aist.go.jp with ESMTP id m942j3Oo015348; Sat, 4 Oct 2008 11:45:03 +0900 (JST) env-from (handa@m17n.org) Original-Received: from smtp1.aist.go.jp by rqsmtp1.aist.go.jp with ESMTP id m942j3mQ024371; Sat, 4 Oct 2008 11:45:03 +0900 (JST) env-from (handa@m17n.org) Original-Received: by smtp1.aist.go.jp with ESMTP id m942j2cA026213; Sat, 4 Oct 2008 11:45:02 +0900 (JST) env-from (handa@m17n.org) Original-Received: from handa by etlken.m17n.org with local (Exim 4.69) (envelope-from ) id 1Klx8g-0006dS-Iv; Sat, 04 Oct 2008 11:45:02 +0900 In-reply-to: <48E64E88.4040305@gmx.at> (message from martin rudalics on Fri, 03 Oct 2008 18:55:36 +0200) User-Agent: SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.2 Emacs/23.0.60 (i686-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) X-detected-operating-system: by monty-python.gnu.org: Solaris 9 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:104338 Archived-At: In article <48E64E88.4040305@gmx.at>, martin rudalics writes: > (font_matching_entity): Reflect ATTRS in font selection. > (font_find_for_lface) [HAVE_NS]: Don't ignore case. > There's something strange with that change. The lines > ASET (spec, FONT_TYPE_INDEX, ftype); > ASET (spec, FONT_SIZE_INDEX, size); > before line 2802 > font_add_log ("match", work, entity); > disappeared. I don't have the slightest idea whether that's of > any importance. Moreover, "spec" should probably become "work" > here. Handa-san? That disappearance is because of Adrian's change just a few hours after of my commit. But, that is ok because font_matching_entity now uses "work" and don't modify "spec", the above two lines are not necessary. And, the code I checked in had a problem of not setting font size of "work", but that is already fixed by Adrian too. By the way, Adrian, please add ChangeLog entry for them: (Just saying "Fix previous change" is ok). So, I don't know what is wrong with the current code, and I can't reproduce your problem even with this setting of yours: --8<---------------cut here---------------start------------->8--- *FontBackend: xft,x Emacs.FontBackend: xft,x emacs.font: DejaVu Sans Mono-9 --8<---------------cut here---------------end--------------->8--- --- Kenichi Handa handa@ni.aist.go.jp