From: Kenichi Handa <handa@m17n.org>
To: martin rudalics <rudalics@gmx.at>
Cc: srivasta@ieee.org, emacs-devel@gnu.org
Subject: Re: Recent CVS Emacs breaks color-themes
Date: Sat, 04 Oct 2008 11:45:02 +0900 [thread overview]
Message-ID: <E1Klx8g-0006dS-Iv@etlken.m17n.org> (raw)
In-Reply-To: <48E64E88.4040305@gmx.at> (message from martin rudalics on Fri, 03 Oct 2008 18:55:36 +0200)
In article <48E64E88.4040305@gmx.at>, martin rudalics <rudalics@gmx.at> writes:
> (font_matching_entity): Reflect ATTRS in font selection.
> (font_find_for_lface) [HAVE_NS]: Don't ignore case.
> There's something strange with that change. The lines
> ASET (spec, FONT_TYPE_INDEX, ftype);
> ASET (spec, FONT_SIZE_INDEX, size);
> before line 2802
> font_add_log ("match", work, entity);
> disappeared. I don't have the slightest idea whether that's of
> any importance. Moreover, "spec" should probably become "work"
> here. Handa-san?
That disappearance is because of Adrian's change just a few
hours after of my commit. But, that is ok because
font_matching_entity now uses "work" and don't modify
"spec", the above two lines are not necessary.
And, the code I checked in had a problem of not setting font
size of "work", but that is already fixed by Adrian too.
By the way, Adrian, please add ChangeLog entry for them:
(Just saying "Fix previous change" is ok).
So, I don't know what is wrong with the current code, and I
can't reproduce your problem even with this setting of
yours:
--8<---------------cut here---------------start------------->8---
*FontBackend: xft,x
Emacs.FontBackend: xft,x
emacs.font: DejaVu Sans Mono-9
--8<---------------cut here---------------end--------------->8---
---
Kenichi Handa
handa@ni.aist.go.jp
next prev parent reply other threads:[~2008-10-04 2:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-03 5:44 Recent CVS Emacs breaks color-themes Manoj Srivastava
2008-10-03 12:51 ` Stefan Monnier
2008-10-03 13:46 ` martin rudalics
2008-10-03 15:36 ` Manoj Srivastava
2008-10-03 16:55 ` martin rudalics
2008-10-04 2:45 ` Kenichi Handa [this message]
2008-10-04 4:58 ` Manoj Srivastava
2008-10-06 2:22 ` Kenichi Handa
2008-10-06 3:13 ` Manoj Srivastava
2008-10-06 4:01 ` Kenichi Handa
2008-10-06 5:23 ` Manoj Srivastava
2008-10-08 12:22 ` Kenichi Handa
2008-10-08 16:31 ` Miles Bader
2008-10-09 4:31 ` Manoj Srivastava
2008-10-09 5:16 ` Kenichi Handa
2008-10-09 12:22 ` Kenichi Handa
2008-10-10 8:43 ` Manoj Srivastava
2008-10-06 7:01 ` Manoj Srivastava
2008-10-06 7:28 ` Manoj Srivastava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1Klx8g-0006dS-Iv@etlken.m17n.org \
--to=handa@m17n.org \
--cc=emacs-devel@gnu.org \
--cc=rudalics@gmx.at \
--cc=srivasta@ieee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.