bug#1065: patch - fix crash in ftfont rendering

bug#1065: patch - fix crash in ftfont rendering

[klchxbec]

Hello,

This is a fix for a crash in otf font rendering. Emacs crashed for me when gsub_gpos->FeatureList.FeatureCount
was zero and otf_langsys->FeatureCount was 2377.

Index: ftfont.c
===================================================================
RCS file: /sources/emacs/emacs/src/ftfont.c,v
retrieving revision 1.31
diff -u -r1.31 ftfont.c
--- ftfont.c	17 Sep 2008 11:48:00 -0000	1.31
+++ ftfont.c	2 Oct 2008 14:25:59 -0000
@@ -1357,7 +1357,7 @@
 	  else
 	    break;
 
-	  for (features = Qnil, k = otf_langsys->FeatureCount - 1; k >= 0; k--)
+	  for (features = Qnil, k = gsub_gpos->FeatureList.FeatureCount - 1; k >= 0; k--)
 	    {
 	      OTF_TAG_SYM (sym, gsub_gpos->FeatureList.Feature[k].FeatureTag);
 	      features = Fcons (sym, features);





Unbegrenzter Speicher, Top-Spamschutz, 120 SMS und eigene E-MailDomain inkl.
http://office.freenet.de/dienste/emailoffice/produktuebersicht/power/mail/index.html

bug#1190: patch - fix crash in ftfont rendering

[Kenichi Handa]

I'm very sorry for the late response.

In article <E1KlP9J-0006lR-Cr@www9.emo.freenet-rz.de>, klchxbec@freenet.de writes:

> This is a fix for a crash in otf font rendering. Emacs crashed for me when gsub_gpos->FeatureList.FeatureCount
> was zero and otf_langsys->FeatureCount was 2377.
[...]
> -	  for (features = Qnil, k = otf_langsys->FeatureCount - 1; k >= 0; k--)
> +	  for (features = Qnil, k = gsub_gpos->FeatureList.FeatureCount - 1; k >= 0; k--)

As this part is collecting features for a specific language,
the above change is not good.   I'll fix the code so that
invalid otf_langsys->FeatureCount doesn't lead to crash.
Could you tell me which font causes this problem?

---
Kenichi Handa
handa@ni.aist.go.jp

bug#1190: marked as done (patch - fix crash in ftfont rendering)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 836 bytes --]


Your message dated Fri, 24 Oct 2008 20:03:55 -0400
with message-id <87ljwdlevo.fsf@cyd.mit.edu>
and subject line Re: patch - fix crash in ftfont rendering
has caused the Emacs bug report #1065,
regarding patch - fix crash in ftfont rendering
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
1065: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1065
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3306 bytes --]

From: Kenichi Handa <handa@m17n.org>
To: klchxbec@freenet.de
Cc: bug-gnu-emacs@gnu.org
Subject: Re: patch - fix crash in ftfont rendering
Date: Fri, 17 Oct 2008 10:39:13 +0900
Message-ID: <E1KqeJ7-0002ZG-SF@etlken.m17n.org>

I'm very sorry for the late response.

In article <E1KlP9J-0006lR-Cr@www9.emo.freenet-rz.de>, klchxbec@freenet.de writes:

> This is a fix for a crash in otf font rendering. Emacs crashed for me when gsub_gpos->FeatureList.FeatureCount
> was zero and otf_langsys->FeatureCount was 2377.
[...]
> -	  for (features = Qnil, k = otf_langsys->FeatureCount - 1; k >= 0; k--)
> +	  for (features = Qnil, k = gsub_gpos->FeatureList.FeatureCount - 1; k >= 0; k--)

As this part is collecting features for a specific language,
the above change is not good.   I'll fix the code so that
invalid otf_langsys->FeatureCount doesn't lead to crash.
Could you tell me which font causes this problem?

---
Kenichi Handa
handa@ni.aist.go.jp




[-- Attachment #3: Type: message/rfc822, Size: 973 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: 1065-done@emacsbugs.donarmstrong.com
Subject: Re: patch - fix crash in ftfont rendering
Date: Fri, 24 Oct 2008 20:03:55 -0400
Message-ID: <87ljwdlevo.fsf@cyd.mit.edu>

I believe Handa's 2008-10-24 change fixed this.

bug#1065: marked as done (patch - fix crash in ftfont rendering)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 836 bytes --]


Your message dated Fri, 24 Oct 2008 20:03:55 -0400
with message-id <87ljwdlevo.fsf@cyd.mit.edu>
and subject line Re: patch - fix crash in ftfont rendering
has caused the Emacs bug report #1065,
regarding patch - fix crash in ftfont rendering
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
1065: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1065
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 3448 bytes --]

From: klchxbec@freenet.de
To: bug-gnu-emacs@gnu.org
Cc: handa@m17n.org
Subject: patch - fix crash in ftfont rendering
Date: Thu, 02 Oct 2008 16:27:25 +0200
Message-ID: <E1KlP9J-0006lR-Cr@www9.emo.freenet-rz.de>

Hello,

This is a fix for a crash in otf font rendering. Emacs crashed for me when gsub_gpos->FeatureList.FeatureCount
was zero and otf_langsys->FeatureCount was 2377.

Index: ftfont.c
===================================================================
RCS file: /sources/emacs/emacs/src/ftfont.c,v
retrieving revision 1.31
diff -u -r1.31 ftfont.c
--- ftfont.c	17 Sep 2008 11:48:00 -0000	1.31
+++ ftfont.c	2 Oct 2008 14:25:59 -0000
@@ -1357,7 +1357,7 @@
 	  else
 	    break;
 
-	  for (features = Qnil, k = otf_langsys->FeatureCount - 1; k >= 0; k--)
+	  for (features = Qnil, k = gsub_gpos->FeatureList.FeatureCount - 1; k >= 0; k--)
 	    {
 	      OTF_TAG_SYM (sym, gsub_gpos->FeatureList.Feature[k].FeatureTag);
 	      features = Fcons (sym, features);





Unbegrenzter Speicher, Top-Spamschutz, 120 SMS und eigene E-MailDomain inkl.
http://office.freenet.de/dienste/emailoffice/produktuebersicht/power/mail/index.html





[-- Attachment #3: Type: message/rfc822, Size: 973 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: 1065-done@emacsbugs.donarmstrong.com
Subject: Re: patch - fix crash in ftfont rendering
Date: Fri, 24 Oct 2008 20:03:55 -0400
Message-ID: <87ljwdlevo.fsf@cyd.mit.edu>

I believe Handa's 2008-10-24 change fixed this.