From: Kenichi Handa <handa@m17n.org>
To: Romain Francoise <romain@orebokech.com>
Cc: cyd@stupidchicken.com, emacs-devel@gnu.org
Subject: Re: composition bug
Date: Thu, 18 Sep 2008 10:23:23 +0900 [thread overview]
Message-ID: <E1Kg8Et-0002gk-LN@etlken.m17n.org> (raw)
In-Reply-To: <873ajy603u.fsf@elegiac.orebokech.com> (message from Romain Francoise on Wed, 17 Sep 2008 21:31:01 +0200)
In article <873ajy603u.fsf@elegiac.orebokech.com>, Romain Francoise <romain@orebokech.com> writes:
> Kenichi Handa <handa@m17n.org> writes:
> > (gdb) br composite.c:1432
> Thanks, I should have started there because the problem was
> immediately obvious when in gdb: an EMACS_INT arg was being
> given the literal -1, which is int. On my machine (amd64),
> EMACS_INT is long and due to the traditional function prototype
> the value isn't casted automatically. I installed a fix.
Ah!!! Thank you for fixing it.
> By the way, it looks like the functions in this file use int for
> buffer positions in many places, there could be other bugs like this
> one. Building with `-Wtraditional-conversion' on amd64 finds quite
> a few occurrences of width mismatch.
I'm always confused by int and EMACS_INT. "struct it" and
"struct text_pos" in dispextern.h uses "int" for
buffer/string positions, and xdisp.c calls functions in
composite.c with those values. So, there exist mixture of
int and EMACS_INT. Shouldn't all of them use EMACS_INT for
positions (and perhaps for string length)?
---
Kenichi Handa
handa@ni.aist.go.jp
next prev parent reply other threads:[~2008-09-18 1:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-07 19:37 composition bug Chong Yidong
2008-09-08 6:36 ` Kenichi Handa
2008-09-08 12:19 ` Romain Francoise
2008-09-09 2:07 ` Kenichi Handa
2008-09-09 5:39 ` Romain Francoise
2008-09-09 7:20 ` Kenichi Handa
2008-09-09 7:40 ` Juanma Barranquero
2008-09-11 2:06 ` Kenichi Handa
2008-09-11 5:34 ` Romain Francoise
2008-09-13 10:09 ` Romain Francoise
2008-09-16 6:24 ` Kenichi Handa
2008-09-16 6:41 ` Romain Francoise
2008-09-16 7:51 ` Kenichi Handa
2008-09-16 17:17 ` Romain Francoise
2008-09-17 5:34 ` Kenichi Handa
2008-09-17 19:31 ` Romain Francoise
2008-09-18 1:23 ` Kenichi Handa [this message]
2008-09-18 6:08 ` Stefan Monnier
2008-09-19 2:29 ` Kenichi Handa
2008-09-19 2:44 ` Stefan Monnier
2008-09-19 3:48 ` Kenichi Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1Kg8Et-0002gk-LN@etlken.m17n.org \
--to=handa@m17n.org \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=romain@orebokech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.