From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard M Stallman Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Window-groups Date: Mon, 23 Jun 2008 10:14:40 -0400 Message-ID: References: Reply-To: rms@gnu.org NNTP-Posting-Host: lo.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: ger.gmane.org 1214230578 16204 80.91.229.12 (23 Jun 2008 14:16:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 23 Jun 2008 14:16:18 +0000 (UTC) Cc: emacs-devel@gnu.org To: joakim@verona.se Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 23 16:17:02 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KAmql-0002P5-Qv for ged-emacs-devel@m.gmane.org; Mon, 23 Jun 2008 16:16:56 +0200 Original-Received: from localhost ([127.0.0.1]:38979 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KAmpw-0006MO-Dr for ged-emacs-devel@m.gmane.org; Mon, 23 Jun 2008 10:16:04 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KAmoj-0005hU-CD for emacs-devel@gnu.org; Mon, 23 Jun 2008 10:14:49 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KAmog-0005fc-PT for emacs-devel@gnu.org; Mon, 23 Jun 2008 10:14:48 -0400 Original-Received: from [199.232.76.173] (port=40054 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KAmog-0005fO-K4 for emacs-devel@gnu.org; Mon, 23 Jun 2008 10:14:46 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:33301) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KAmog-0003yL-S5 for emacs-devel@gnu.org; Mon, 23 Jun 2008 10:14:46 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1KAmoa-00067N-JJ; Mon, 23 Jun 2008 10:14:40 -0400 In-reply-to: (joakim@verona.se) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:99780 Archived-At: +(defun window-group-create (window) + "Return a window group object with WINDOW as its only member. +An error is signalled if WINDOW is not visible or already part of +a group." That's ambiguous -- it is not clear whether "not" covers the second disjunct. I suggest "...is not visible or if it is already..." Also, "An error is signalled" is passive. Please try to stick to the active voice whenever that isn't difficult to do. +The windows in the group are not deleted." More passive voice. It will be clearer if you make it active. +;; Here's some examples. "Here are". +(defun window-group-members (group) + "Return all windows in GROUP. +Must be in selected frame." That last sentence is very vague.