From: Richard M Stallman <rms@gnu.org>
To: joakim@verona.se
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Window-groups
Date: Mon, 23 Jun 2008 10:14:40 -0400 [thread overview]
Message-ID: <E1KAmoa-00067N-JJ@fencepost.gnu.org> (raw)
In-Reply-To: <m31w2p2srj.fsf@verona.se> (joakim@verona.se)
+(defun window-group-create (window)
+ "Return a window group object with WINDOW as its only member.
+An error is signalled if WINDOW is not visible or already part of
+a group."
That's ambiguous -- it is not clear whether "not" covers the second
disjunct. I suggest "...is not visible or if it is already..."
Also, "An error is signalled" is passive. Please try to stick to the
active voice whenever that isn't difficult to do.
+The windows in the group are not deleted."
More passive voice. It will be clearer if you make it active.
+;; Here's some examples.
"Here are".
+(defun window-group-members (group)
+ "Return all windows in GROUP.
+Must be in selected frame."
That last sentence is very vague.
next prev parent reply other threads:[~2008-06-23 14:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-22 19:07 [PATCH] Window-groups joakim
2008-06-23 14:14 ` Richard M Stallman [this message]
2008-06-23 14:14 ` Richard M Stallman
2008-06-23 14:14 ` Richard M Stallman
2008-06-23 14:29 ` joakim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1KAmoa-00067N-JJ@fencepost.gnu.org \
--to=rms@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=joakim@verona.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.