bug#445: Invalid read syntax in savehist-mode's history file

bug#445: Invalid read syntax in savehist-mode's history file

[Daniel Colascione]

I found this line in my ~/.emacs.d/history. I've trimmed the list to
include only the problematic element and formatted it for email.

(setq command-history
      ...  
      '(describe-key-briefly
        '[mode-line (down-mouse-1
                     (#<window 199> mode-line (110 . 617)
                               -97640112
                               ("Calc: 12 Deg               " . 6)
                               41 (13 . 47) nil (5 . 9) (8 . 16)))] nil 1)
      ...)

The lisp reader complains about the #<window 199>.


In GNU Emacs 22.1.1 (i386-redhat-linux-gnu, GTK+ Version 2.12.5)
 of 2008-05-05 on xenbuilder2.fedora.redhat.com
Windowing system distributor `The X.Org Foundation', version 11.0.10300000
configured using `configure  '--build=i386-redhat-linux-gnu' '--host=i386-redhat-linux-gnu' '--target=i386-redhat-linux-gnu' '--program-prefix=' '--prefix=/usr' '--exec-prefix=/usr' '--bindir=/usr/bin' '--sbindir=/usr/sbin' '--sysconfdir=/etc' '--datadir=/usr/share' '--includedir=/usr/include' '--libdir=/usr/lib' '--libexecdir=/usr/libexec' '--localstatedir=/var' '--sharedstatedir=/usr/com' '--mandir=/usr/share/man' '--infodir=/usr/share/info' '--with-pop' '--with-sound' '--with-gtk' 'build_alias=i386-redhat-linux-gnu' 'host_alias=i386-redhat-linux-gnu' 'target_alias=i386-redhat-linux-gnu' 'CFLAGS=-DMAIL_USE_LOCKF -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions --param=ssp-buffer-size=4 -m32 -march=i386 -mtune=generic -fasynchronous-unwind-tables''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8
  default-enable-multibyte-characters: t

Major mode: Emacs-Lisp

Minor modes in effect:
  eldoc-mode: t
  paredit-mode: t
  cua-mode: t
  global-hi-lock-mode: t
  hi-lock-mode: t
  show-paren-mode: t
  shell-dirtrack-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  unify-8859-on-encoding-mode: t
  utf-translate-cjk-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
C-x b m e s <return> M-< M-> C-x C-f <backspace> . 
<tab> <tab> d <tab> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> . e 
<tab> m <tab> . d <tab> h i s <tab> <return> C-s # 
C-s C-s C-s C-r C-r C-r C-r C-r <left> <home> M-< C-s 
# < w i n d o w C-s <home> C-s # w <backspace> < w 
i n d <left> C-s C-s <left> M-x r e p o r t - e m <tab> 
<return>

Recent messages:
Making completion list...
Loading "/net/home/danc/.emacs.d/byte-cache/net!home!danc!emacs!misc!paredit.elc" as "/net/home/danc/emacs/misc/paredit.el"...
Loading edmacro...done
Loading "/net/home/danc/.emacs.d/byte-cache/net!home!danc!emacs!misc!paredit.elc" as "/net/home/danc/emacs/misc/paredit.el"...done
Loading "/net/home/danc/.emacs.d/byte-cache/net!home!danc!emacs!misc!trailing-whitespace.elc" as "/net/home/danc/emacs/misc/trailing-whitespace.el"...done
Loading eldoc...done
Mark saved where search started
Mark set
Mark saved where search started [2 times]
Loading emacsbug...done

bug#445: Invalid read syntax in savehist-mode's history file

[Chong Yidong]

> I found this line in my ~/.emacs.d/history. I've trimmed the list to
> include only the problematic element and formatted it for email.
>
> (setq command-history
>       ...  
>       '(describe-key-briefly
>         '[mode-line (down-mouse-1
>                      (#<window 199> mode-line (110 . 617)
>                                -97640112
>                                ("Calc: 12 Deg               " . 6)
>                                41 (13 . 47) nil (5 . 9) (8 . 16)))] nil 1)
>       ...)
>
> The lisp reader complains about the #<window 199>.

AFAIK, savehist-mode doesn't save command-history.  Please provide a
recipe for reproducing this bug.

bug#445: Invalid read syntax in savehist-mode's history file

[Daniel Colascione]

On Mon, Aug 18, 2008 at 3:43 PM, Chong Yidong <cyd@stupidchicken.com> wrote:
> AFAIK, savehist-mode doesn't save command-history.  Please provide a
> recipe for reproducing this bug.

Actually, it's moot: the CVS savehist.el delicately works around the
problem, starting at line 314 in my copy.

bug#445: Invalid read syntax in savehist-mode's history file

[martin rudalics]

 > AFAIK, savehist-mode doesn't save command-history.  Please provide a
 > recipe for reproducing this bug.

The comment below seems to contradict this

   (defcustom savehist-ignored-variables nil ;; '(command-history)

but I'm a stranger here.

martin

bug#445: Invalid read syntax in savehist-mode's history file

[Drew Adams]

>  > AFAIK, savehist-mode doesn't save command-history.  Please 
>  > provide a recipe for reproducing this bug.
> 
> The comment below seems to contradict this
>    (defcustom savehist-ignored-variables nil ;; '(command-history)
> but I'm a stranger here.

Yes, you need a recipe and knowledge of the user's savehist variables. It's
likely that 
`savehist-save-hook' added `command-history' to
`savehist-minibuffer-history-variables'. That is the default behavior (and a
good one), since `savehist-ignored-variables' is nil by default.

Another, less likely possibility is that `command-history' was included in
`savehist-additional-variables' or `savehist-save-minibuffer-history'.

My own values, FWIW:

`savehist-additional-variables' is (search-ring regexp-search-ring)

`savehist-save-minibuffer-history' is t

`savehist-minibuffer-history-variables' is automatically set to:
(color-theme-history iswitchb-history icicle-face-name-history find-tag-history
icicle-doc-history junk-ring woman-file-history woman-topic-history
icicle-command-abbrev-history ediff-url-read-url-history grep-find-history
variable-name-history widget-function-prompt-value-history
icicle-font-name-history hi-lock-face-history hi-lock-regexp-history
shell-command-history icicle-search-replacement-history
icicle-function-name-history face-name-history icicle-function-history
icicle-text-property-value-history icicle-dictionary-history icicle-kill-history
icicle-color-theme-history icicle-bookmark-history icicle-kmacro-history
icicle-buffer-config-history icicle-search-history icicle-completion-set-history
frame-name-history comint-input-ring dired-shell-command-history
imenu--history-list compile-history Info-search-history search-ring
dired-regexp-history info-lookup-history coding-system-history synonyms-history
icicle-thesaurus-history input-method-history minibuffer-history-search-history
bookmark-history set-any-variable-value-history yes-or-no-p-history
set-variable-value-history query-replace-history grep-history
read-expression-history buffer-name-history command-history regexp-history
file-name-history minibuffer-history extended-command-history)

As you can see, `command-history' was automatically added to
`savehist-minibuffer-history-variables' (because
`savehist-save-minibuffer-history' is t).