From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Richard M Stallman <rms@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: byte-compile-nogroup-warn effectively disabled
Date: Sun, 08 Jun 2008 18:06:14 -0400
Message-ID: <E1K5T1i-0003CO-Jm@fencepost.gnu.org>
Reply-To: rms@gnu.org
NNTP-Posting-Host: lo.gmane.org
Content-Type: text/plain; charset=ISO-8859-15
X-Trace: ger.gmane.org 1212962907 12365 80.91.229.12 (8 Jun 2008 22:08:27 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Sun, 8 Jun 2008 22:08:27 +0000 (UTC)
To: emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 09 00:09:10 2008
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([199.232.76.165])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1K5T4X-0007F1-2Z
	for ged-emacs-devel@m.gmane.org; Mon, 09 Jun 2008 00:09:09 +0200
Original-Received: from localhost ([127.0.0.1]:46892 helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1K5T3k-0006y9-0M
	for ged-emacs-devel@m.gmane.org; Sun, 08 Jun 2008 18:08:20 -0400
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1K5T3f-0006xn-2f
	for emacs-devel@gnu.org; Sun, 08 Jun 2008 18:08:15 -0400
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1K5T3d-0006xK-Gf
	for emacs-devel@gnu.org; Sun, 08 Jun 2008 18:08:14 -0400
Original-Received: from [199.232.76.173] (port=53172 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1K5T3d-0006xH-DS
	for emacs-devel@gnu.org; Sun, 08 Jun 2008 18:08:13 -0400
Original-Received: from fencepost.gnu.org ([140.186.70.10]:48784)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <rms@gnu.org>) id 1K5T3d-0001fC-Oy
	for emacs-devel@gnu.org; Sun, 08 Jun 2008 18:08:13 -0400
Original-Received: from rms by fencepost.gnu.org with local (Exim 4.67)
	(envelope-from <rms@gnu.org>)
	id 1K5T1i-0003CO-Jm; Sun, 08 Jun 2008 18:06:14 -0400
X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:98733
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/98733>

This change

     ;; Warn if a custom definition fails to specify :group.
     (defun byte-compile-nogroup-warn (form)

    +  (if (and (memq (car form) '(custom-declare-face custom-declare-variable))
    +           byte-compile-current-group)
    +      ;; The group will be provided implicitly.
    +      nil

effectively defeats the point of that warning, which is to
make sure that every defcustom and defface specifies the group.