23.0.60; Underlining text including U+00F6, U+00E4

23.0.60; Underlining text including U+00F6, U+00E4

[Markus Triska]

When I open the following file (enriched-mode) with "emacs -Q":

   http://www.logic.at/prolog/test.doc

it looks like this:

   http://www.logic.at/prolog/test.png

All characters up to, and including, U+00F6 are underlined, and the
following are not, although test.doc says all should be underlined.

This also occurs, for example, in message titles with Gnus (where the
current mail is underlined), if an author name contains U+00E4, U+00E9
and several others.

In GNU Emacs 23.0.60.2 (i386-apple-darwin8.11.1, GTK+ Version 2.12.9)
 of 2008-05-19 on mt-computer.local
Windowing system distributor `The XFree86 Project, Inc', version 11.0.40400000
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t

Re: 23.0.60; Underlining text including U+00F6, U+00E4

[Kenichi Handa]

In article <20080522125825.8F2F2889A35@mt-computer.local>, Markus Triska <markus.triska@gmx.at> writes:

> When I open the following file (enriched-mode) with "emacs -Q":

>    http://www.logic.at/prolog/test.doc

> it looks like this:

>    http://www.logic.at/prolog/test.png

> All characters up to, and including, U+00F6 are underlined, and the
> following are not, although test.doc says all should be underlined.

I've just installed a fix.

---
Kenichi Handa
handa@ni.aist.go.jp

Re: 23.0.60; Underlining text including U+00F6, U+00E4

[YAMAMOTO Mitsuharu]

>>>>> On Fri, 23 May 2008 13:45:32 +0900, Kenichi Handa <handa@m17n.org> said:

> In article <20080522125825.8F2F2889A35@mt-computer.local>, Markus
> Triska <markus.triska@gmx.at> writes:
>> When I open the following file (enriched-mode) with "emacs -Q":

>> http://www.logic.at/prolog/test.doc

>> it looks like this:

>> http://www.logic.at/prolog/test.png

>> All characters up to, and including, U+00F6 are underlined, and the
>> following are not, although test.doc says all should be underlined.

> I've just installed a fix.

Isn't `position' supposed to be relative to the baseline?  If so,
these lines in xterm.c seems to be wrong.

  2727		      if (x_underline_at_descent_line)
  2728			position = (s->height - thickness) - s->ybase;

  2748		  if (s->y + s->height <= s->ybase + position)
  2749		    position = s->y + s->height - 1;

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

Re: 23.0.60; Underlining text including U+00F6, U+00E4

[Kenichi Handa]

In article <wlve15nt8g.wl%mituharu@math.s.chiba-u.ac.jp>, YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> writes:

> Isn't `position' supposed to be relative to the baseline?  If so,
> these lines in xterm.c seems to be wrong.

>   2727		      if (x_underline_at_descent_line)
>   2728			position = (s->height - thickness) - s->ybase;

>   2748		  if (s->y + s->height <= s->ybase + position)
>   2749		    position = s->y + s->height - 1;

Oops, thank you for pointing out that.  You are right.  But,
as I'm now at home, and can't commit a fix.  I'll fix it
next week, or if you can, please go ahead.

---
Kenichi Handa
handa@ni.aist.go.jp

Re: 23.0.60; Underlining text including U+00F6, U+00E4

[Kenichi Handa]

In article <E1JzgkC-0005TM-3X@etlken.m17n.org>, Kenichi Handa <handa@m17n.org> writes:

> In article <wlve15nt8g.wl%mituharu@math.s.chiba-u.ac.jp>, YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> writes:
> > Isn't `position' supposed to be relative to the baseline?  If so,
> > these lines in xterm.c seems to be wrong.

> >   2727		      if (x_underline_at_descent_line)
> >   2728			position = (s->height - thickness) - s->ybase;

> >   2748		  if (s->y + s->height <= s->ybase + position)
> >   2749		    position = s->y + s->height - 1;

> Oops, thank you for pointing out that.  You are right.  But,
> as I'm now at home, and can't commit a fix.  I'll fix it
> next week, or if you can, please go ahead.

I've just installed a fix.

---
Kenichi Handa
handa@ni.aist.go.jp

bug#297: marked as done (23.0.60; Underlining text including U+00F6, U+00E4)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 865 bytes --]


Your message dated Mon, 26 May 2008 23:48:47 -0400
with message-id <87ej7obe5c.fsf@stupidchicken.com>
and subject line Re: 23.0.60; Underlining text including U+00F6, U+00E4
has caused the Emacs bug report #297,
regarding 23.0.60; Underlining text including U+00F6, U+00E4
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don@donarmstrong.com
immediately.)


-- 
297: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=297
Emacs Bug Tracking System
Contact don@donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 5517 bytes --]

From: Markus Triska <markus.triska@gmx.at>
To: emacs-pretest-bug@gnu.org
Cc: 
Subject: 23.0.60; Underlining text including U+00F6, U+00E4
Date: Thu, 22 May 2008 14:58:25 +0200 (CEST)
Message-ID: <20080522125825.8F2F2889A35@mt-computer.local>


When I open the following file (enriched-mode) with "emacs -Q":

   http://www.logic.at/prolog/test.doc

it looks like this:

   http://www.logic.at/prolog/test.png

All characters up to, and including, U+00F6 are underlined, and the
following are not, although test.doc says all should be underlined.

This also occurs, for example, in message titles with Gnus (where the
current mail is underlined), if an author name contains U+00E4, U+00E9
and several others.

In GNU Emacs 23.0.60.2 (i386-apple-darwin8.11.1, GTK+ Version 2.12.9)
 of 2008-05-19 on mt-computer.local
Windowing system distributor `The XFree86 Project, Inc', version 11.0.40400000
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t






[-- Attachment #3: Type: message/rfc822, Size: 1083 bytes --]

From: Chong Yidong <cyd@stupidchicken.com>
To: 297-done@emacsbugs.donarmstrong.com
Subject: Re: 23.0.60; Underlining text including U+00F6, U+00E4
Date: Mon, 26 May 2008 23:48:47 -0400
Message-ID: <87ej7obe5c.fsf@stupidchicken.com>

Closing the bug.  Handa fixed it:

http://lists.gnu.org/archive/html/emacs-devel/2008-05/msg01431.html