all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Kenichi Handa <handa@m17n.org>
To: Jason Rumney <jasonr@gnu.org>
Cc: eliz@gnu.org, lennart.borgman@gmail.com,
	monnier@IRO.UMontreal.CA, emacs-devel@gnu.org
Subject: Re: Memory leak
Date: Mon, 19 May 2008 17:05:42 +0900	[thread overview]
Message-ID: <E1Jy0NK-0000I6-BP@etlken.m17n.org> (raw)
In-Reply-To: <482D8332.5030908@gnu.org> (message from Jason Rumney on Fri, 16 May 2008 13:50:58 +0100)

In article <482D8332.5030908@gnu.org>, Jason Rumney <jasonr@gnu.org> writes:

> If the leak is coming from the font cache, then I wouldn't expect it to 
> be released when the frame is deleted, as the font cache is shared 
> between all frames on w32 (and I think between all frames on the same 
> display on X). Stefan is seeing 10x the increase as you are on Windows, 
> which could be explained by xft loading fonts into Emacs's process 
> space, while on Windows the font itself stays in system owned memory, 
> and only Emacs's internal info that it associates with the font 
> contributes to the growth. That also points to fonts being responsible 
> (though circumstantial).

I've just installed a fix in font-cache handling.  Now, even
when I create many new frames, the memory usage doesn't
increase that much.  Though it still increases several
handreds K-bytes each time a new frame is created, and it is
not reduced when I delete the frames.  So, I think there
still be a problem somewhere.

FYI, when I compile Emacs without gtk, the amount of
(non-freed) memory increase becomes smaller.

> There is another similar problem when we get text extents - each redraw 
> cycle can call w32font_text_extents a number of times for the same 
> glyph_string (from compute_glyph_string_overhangs, left_overwriting and 
> right_overwriting in quick succession in draw_glyphs, with nested 
> compute_overhangs_and_x within some of the if statements that cause 
> extra calls for preceding and following glyph_strings if there is 
> overhang, which there often is with antialising enabled). Perhaps this 
> operation is cheap with the X font backends, but on Windows it is 
> expensive (even with caching of metrics), and I suspect this is a major 
> cause of the slowdown reported by Windows users.

I remember that I modified x_draw_glyph_string for such a
font-backend as xft that can't do foreground-only drawing
because of antialiasing, which increases the count of
overhang-checking.  Perhaps we should study the code of
draw_glyphs and x_draw_glyph_string and find a solution.

---
Kenichi Handa
handa@ni.aist.go.jp





  reply	other threads:[~2008-05-19  8:05 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-15 22:50 Memory leak Stefan Monnier
2008-05-15 23:06 ` David Kastrup
2008-05-16  0:25   ` Lennart Borgman (gmail)
2008-05-16  8:35     ` Eli Zaretskii
2008-05-16  9:03       ` Juanma Barranquero
2008-05-16  9:25         ` Eli Zaretskii
2008-05-16  9:29           ` Juanma Barranquero
2008-05-16  9:46             ` Eli Zaretskii
2008-05-16  9:49             ` Juanma Barranquero
2008-05-16 20:13               ` Stephen J. Turnbull
2008-05-16 21:15                 ` [OT, silly] " Thomas Lord
2008-05-16 20:41           ` David Robinow
2008-05-16 21:36             ` Lennart Borgman (gmail)
2008-05-17  7:10             ` Eli Zaretskii
2008-05-16  9:43     ` Eli Zaretskii
2008-05-16 12:50       ` Jason Rumney
2008-05-19  8:05         ` Kenichi Handa [this message]
2008-05-19  8:45           ` YAMAMOTO Mitsuharu
2008-05-19 11:13             ` Kenichi Handa
2008-05-19 11:59               ` YAMAMOTO Mitsuharu
2008-05-23  2:24                 ` Kenichi Handa
2008-05-19 13:34           ` David Hansen
2008-05-19 19:42             ` David Hansen
2008-05-24  2:30         ` calculation of text extents [Re: Memory leak] Kenichi Handa
2008-05-16  2:19   ` Memory leak Stefan Monnier
2008-05-16  0:38 ` YAMAMOTO Mitsuharu
2008-05-17 15:16 ` Evil Boris
2008-05-17 19:11   ` Stephen J. Turnbull
2008-05-17 19:17     ` Eric Hanchrow
2008-05-18 11:26       ` Jan Djärv
2008-05-18 11:29         ` David Kastrup
2008-05-20  6:46           ` Jan Djärv
2008-05-18 13:34         ` Werner LEMBERG
2008-05-20  6:48           ` Jan Djärv
2008-05-19  2:44         ` Stephen J. Turnbull
2008-05-20  6:50           ` Jan Djärv
2008-05-21  6:10             ` Stephen J. Turnbull
2008-05-21 17:32               ` Stefan Monnier
2008-05-23 13:54   ` Evil Boris
  -- strict thread matches above, loose matches on Subject: below --
2008-05-30 22:39 memory leak Drew Adams
2008-05-31  7:57 ` David Kastrup
2008-05-24 23:02 Memory leak Nick Roberts
2006-04-28 17:51 memory leak Robert J. Chassell
2006-04-28 18:10 ` Andreas Schwab
2006-04-28 20:25   ` Robert J. Chassell
2006-04-29  1:56 ` Luc Teirlinck
2006-04-29 11:16   ` Robert J. Chassell
2006-04-29 14:06     ` Luc Teirlinck
2006-04-29 16:41       ` Robert J. Chassell
2006-04-29 17:07         ` Luc Teirlinck
2006-04-29 19:32           ` Robert J. Chassell
2006-04-30  3:03     ` Richard Stallman
2006-04-30  4:15       ` Luc Teirlinck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1Jy0NK-0000I6-BP@etlken.m17n.org \
    --to=handa@m17n.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=jasonr@gnu.org \
    --cc=lennart.borgman@gmail.com \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.