From: Kenichi Handa <handa@m17n.org>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: intrigeri@boum.org, 103@emacsbugs.donarmstrong.com, emacs-devel@gnu.org
Subject: Re: 23.0.60; Segmentation fault loading auto-lang.el
Date: Wed, 09 Apr 2008 11:19:43 +0900 [thread overview]
Message-ID: <E1JjPuZ-00052G-Fw@etlken.m17n.org> (raw)
In-Reply-To: <87skxwl29o.fsf@stupidchicken.com> (message from Chong Yidong on Tue, 08 Apr 2008 12:50:11 -0400)
In article <87skxwl29o.fsf@stupidchicken.com>, Chong Yidong <cyd@stupidchicken.com> writes:
> > Any Lisp program that depends on the result of
> > string-as-unibyte (thus Emacs' internal character
> > representation) won't work in Emacs 23.
> I see. However, maybe the following change to regexp-opt-group in
> regexp-opt.el would make things a little more predictable. What do you
> think?
I agree because that change will avoid a unibyte string
being changed to multibyte by accident.
But, I've just downloaded auto-lang.el and found that it
has codes something like this:
(string-as-multibyte
(regexp-opt
(mapcar 'string-as-unibyte
(append
al-german-common-words
al-german-8bit-words
nil))))
All of them should be changed to this simple form:
(regexp-opt (append al-german-common-words al-german-8bit-words))
The above german case works just by chance, but
al-danish-common-words doesn't. You'll see peculiar 8-bit
codes in it.
And, the file should have a coding tag.
---
Kenichi Handa
handa@ni.aist.go.jp
> *** trunk/lisp/emacs-lisp/regexp-opt.el.~1.37.~ 2008-03-14 17:17:34.000000000 -0400
> --- trunk/lisp/emacs-lisp/regexp-opt.el 2008-04-08 12:46:49.000000000 -0400
> ***************
> *** 226,232 ****
> ;; Otherwise, divide the list into those that start with a
> ;; particular letter and those that do not, and recurse on them.
> ! (let* ((char (char-to-string (string-to-char (car strings))))
> (half1 (all-completions char strings))
> (half2 (nthcdr (length half1) strings)))
> (concat open-group
> --- 226,232 ----
> ;; Otherwise, divide the list into those that start with a
> ;; particular letter and those that do not, and recurse on them.
> ! (let* ((char (substring (car strings) 0 1))
> (half1 (all-completions char strings))
> (half2 (nthcdr (length half1) strings)))
> (concat open-group
next prev parent reply other threads:[~2008-04-09 2:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-08 5:29 23.0.60; Segmentation fault loading auto-lang.el Chong Yidong
2008-04-08 6:52 ` Kenichi Handa
2008-04-08 16:50 ` Chong Yidong
2008-04-09 1:42 ` Stefan Monnier
2008-04-09 2:19 ` Kenichi Handa [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-03-30 18:38 intrigeri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1JjPuZ-00052G-Fw@etlken.m17n.org \
--to=handa@m17n.org \
--cc=103@emacsbugs.donarmstrong.com \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=intrigeri@boum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.