From: Kenichi Handa <handa@ni.aist.go.jp>
To: Juri Linkov <juri@jurta.org>
Cc: emacs-pretest-bug@gnu.org, monnier@iro.umontreal.ca
Subject: Re: Crashes with non-default language environments
Date: Tue, 12 Feb 2008 20:23:52 +0900 [thread overview]
Message-ID: <E1JOtEu-0002gO-Sp@etlken.m17n.org> (raw)
In-Reply-To: <87prv4l96f.fsf@jurta.org> (message from Juri Linkov on Mon, 11 Feb 2008 00:48:40 +0200)
In article <87prv4l96f.fsf@jurta.org>, Juri Linkov <juri@jurta.org> writes:
>>> This crash is caused by the corrupt byte-code produced by
>>> `byte-compile-lapcode'. `string-make-unibyte' at the end of this
>>> function produces different bytecode strings in different
>>> language environments. This problem can be narrowed down to:
> >
> > Shouldn't it be string-to-unibyte instead?
> I've just checked that `string-as-unibyte' produces even worse results
> than `string-make-unibyte'. It replaces every byte in the original
> string with 2-byte sequences.
> The change to use `string-as-unibyte' came from the Unicode branch:
> 2008-02-02 Kenichi Handa <handa@m17n.org>
> * emacs-lisp/bytecomp.el (byte-compile-lapcode): Be sure to
> return a unibyte string.
> Maybe, this change is correct, but the bug is in the definition of the
> language environment, I can't say for sure. Comparing results of calling
> `string-make-unibyte' on 256 bytes in different language environments
> gives only 6 differences:
It was my fault. I've just installed this change. Could
you please try with the latest code?
Index: bytecomp.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/emacs-lisp/bytecomp.el,v
retrieving revision 2.229
retrieving revision 2.230
diff -u -r2.229 -r2.230
--- bytecomp.el 1 Feb 2008 16:01:26 -0000 2.229
+++ bytecomp.el 12 Feb 2008 11:21:31 -0000 2.230
@@ -864,7 +864,7 @@
(setcar (cdr bytes) (logand pc 255))
(setcar bytes (lsh pc -8))))
(setq patchlist (cdr patchlist))))
- (string-make-unibyte (concat (nreverse bytes)))))
+ (apply 'unibyte-string (nreverse bytes))))
\f
;;; compile-time evaluation
---
Kenichi Handa
handa@ni.aist.go.jp
next prev parent reply other threads:[~2008-02-12 11:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-07 19:54 Crashes with non-default language environments Juri Linkov
2008-02-09 22:17 ` Juri Linkov
2008-02-10 2:09 ` Stefan Monnier
2008-02-10 22:48 ` Juri Linkov
2008-02-11 1:39 ` Stefan Monnier
2008-02-11 1:56 ` Miles Bader
2008-02-11 3:02 ` Stefan Monnier
2008-02-11 4:11 ` Miles Bader
2008-02-11 14:06 ` Stefan Monnier
2008-02-11 15:16 ` Miles Bader
2008-02-11 16:51 ` Stefan Monnier
2008-02-11 21:27 ` Juri Linkov
2008-02-12 11:41 ` Kenichi Handa
2008-02-12 16:29 ` Stefan Monnier
2008-06-25 2:58 ` bug#481: " Kenichi Handa
2008-06-25 3:49 ` bug#482: " Stefan Monnier
2008-07-02 10:44 ` bug#517: " Kenichi Handa
2008-07-03 22:23 ` bug#529: " Stefan Monnier
2008-07-04 2:27 ` bug#531: " Kenichi Handa
2008-02-12 11:23 ` Kenichi Handa [this message]
2008-02-12 19:29 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1JOtEu-0002gO-Sp@etlken.m17n.org \
--to=handa@ni.aist.go.jp \
--cc=emacs-pretest-bug@gnu.org \
--cc=juri@jurta.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.