[phromo@gmail.com: bugfix: python.el: completion in inferior python]

[Richard Stallman <rms@gnu.org>]

Would someone please DTRT?

------- Start of forwarded message -------
Message-ID: <478E0C9B.8080302@gmail.com>
Date: Wed, 16 Jan 2008 14:54:35 +0100
From: Martin Svenson <phromo@gmail.com>
MIME-Version: 1.0
To: bug-gnu-emacs@gnu.org
Content-Type: multipart/mixed; boundary="------------000101040702080309060500"
Subject: bugfix: python.el: completion in inferior python

This is a multi-part message in MIME format.
- --------------000101040702080309060500
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Hello,

I've fixed a small "bug" that affects, among others, 
python-complete-symbol in the inferior python buffer.

Problem (and solution):
When doing python-complete-symbol in the inferior python buffer, emacs 
freezes. This is due to a while-loop in python-symbol-completions that 
never gets any input, because the python process signals an error that 
python-imports is nil (because we're not in an python-edit-buffer). The 
correct value of python-imports in an unknown context should not be nil 
(as in current version), but "None", which makes things work smoothly 
and as expected.

P.S. This is my first time sending a patch to an open-source project. I 
apolgize if my message does not conform with etiquette.

// Martin


- --------------000101040702080309060500
Content-Type: text/plain;
 name="python-el-completion-fix.patch"
Content-Transfer-Encoding: base64
Content-Disposition: inline;
 filename="python-el-completion-fix.patch"

KioqIHB5dGhvbi5lbC5vbGQJV2VkIEphbiAxNiAxNDoyOTowNCAyMDA4Ci0tLSBweXRob24u
ZWwJV2VkIEphbiAxNiAxNDo0Njo1OCAyMDA4CioqKioqKioqKioqKioqKgoqKiogMTg0OCwx
ODU0ICoqKioKICAMDQogIDs7OzsgQ29tcGxldGlvbi4NCiAgDQohIChkZWZ2YXIgcHl0aG9u
LWltcG9ydHMgbmlsDQogICAgIlN0cmluZyBvZiB0b3AtbGV2ZWwgaW1wb3J0IHN0YXRlbWVu
dHMgdXBkYXRlZCBieSBgcHl0aG9uLWZpbmQtaW1wb3J0cycuIikNCiAgKG1ha2UtdmFyaWFi
bGUtYnVmZmVyLWxvY2FsICdweXRob24taW1wb3J0cykNCiAgDQotLS0gMTg0OCwxODU0IC0t
LS0KICAMDQogIDs7OzsgQ29tcGxldGlvbi4NCiAgDQohIChkZWZ2YXIgcHl0aG9uLWltcG9y
dHMgIk5vbmUiDQogICAgIlN0cmluZyBvZiB0b3AtbGV2ZWwgaW1wb3J0IHN0YXRlbWVudHMg
dXBkYXRlZCBieSBgcHl0aG9uLWZpbmQtaW1wb3J0cycuIikNCiAgKG1ha2UtdmFyaWFibGUt
YnVmZmVyLWxvY2FsICdweXRob24taW1wb3J0cykNCiAgDQo=
- --------------000101040702080309060500--
------- End of forwarded message -------