From: Richard Stallman <rms@gnu.org>
To: emacs-devel@gnu.org
Subject: [nico@ngolde.de: some code issues]
Date: Mon, 07 Jan 2008 06:30:41 -0500 [thread overview]
Message-ID: <E1JBqBl-0004Jr-0n@fencepost.gnu.org> (raw)
Would someone please fix these in Emacs 22, then ack?
------- Start of forwarded message -------
Date: Sat, 5 Jan 2008 18:59:08 +0100
From: Nico Golde <nico@ngolde.de>
To: bug-gnu-emacs@gnu.org
Message-ID: <20080105175908.GA31673@ngolde.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
protocol="application/pgp-signature"; boundary="HlL+5n6rz5pIUxbD"
Content-Disposition: inline
Subject: some code issues
- --HlL+5n6rz5pIUxbD
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Hi,
I had a quick look at the pop.c code today and found some=20
issues.
In pop_stat:
365 if (strncmp (fromserver, "+OK ", 4))
366 {
367 if (0 =3D=3D strncmp (fromserver, "-ERR", 4))
368 {
369 strncpy (pop_error, fromserver, ERROR_MAX);
370 }
371 else
372 {
373 strcpy (pop_error,
374 >=B7=B7=B7 "Unexpected response from POP server in pop_stat");
375 pop_trash (server);
376 }
377 return (-1);
378 }
380 *count =3D atoi (&fromserver[4]);
381=20
382 fromserver =3D index (&fromserver[4], ' ');
383 if (! fromserver)
384 {
385 strcpy (pop_error,
386 >=B7=B7=B7 "Badly formatted response from server in pop_stat");
387 pop_trash (server);
388 return (-1);
389 }
If I don't miss anything the atoi call in 380 is not save as it is not=20
save because it is not ensure that &fromserver[4] is not NULL. A crafted
pop3 server could thus crash emacs. This is of course not a real issue but
wouldn't be nice. Same for the pop_last function.
In pop_list:
440=20
441 *IDs =3D (int *) malloc ((how_many + 1) * sizeof (int));
442 *sizes =3D (int *) malloc ((how_many + 1) * sizeof (int));
443 if (! (*IDs && *sizes))
444 {
445 strcpy (pop_error, "Out of memory in pop_list");
446 return (-1);
447 }
448=20
in 441 and 442 there should be some check for how_many to prevent an integer
overflow here.
Same problem for the xnew macro in etags.c
What do you think about this?
Kind regards
Nico
- --=20
Nico Golde - http://www.ngolde.de - nion@jabber.ccc.de - GPG: 0x73647CFF
For security reasons, all text in this mail is double-rot13 encrypted.
- --HlL+5n6rz5pIUxbD
Content-Type: application/pgp-signature
Content-Disposition: inline
- -----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
iD8DBQFHf8VsHYflSXNkfP8RAtaHAJ9j0CV6prPJ2LCyKdnDvBSLK37R1QCdHQb0
0AfXr+0Yw3F8LR66YGhKOUw=
=tDA3
- -----END PGP SIGNATURE-----
- --HlL+5n6rz5pIUxbD--
------- End of forwarded message -------
next reply other threads:[~2008-01-07 11:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-07 11:30 Richard Stallman [this message]
2008-01-10 15:24 ` [nico@ngolde.de: some code issues] Chong Yidong
2008-01-10 15:27 ` Chong Yidong
2008-01-10 15:35 ` Nico Golde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1JBqBl-0004Jr-0n@fencepost.gnu.org \
--to=rms@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.