question about testing for toolkit

question about testing for toolkit

[Drew Adams]

Richard has explained to me that when Emacs uses "X Window with no toolkit,
`set-frame-size' includes the menu-bar, since it is displayed using ordinary
text lines. In other window system cases it does not include the menu bar."

I want to test this use of X without toolkit. This is code from
`emacs-version':

(cond ((featurep 'motif)
       (concat ", " (substring motif-version-string 4)))
      ((featurep 'gtk)
       (concat ", GTK+ Version " gtk-version-string))
      ((featurep 'x-toolkit) ", X toolkit")
      ((boundp 'mac-carbon-version-string)
       (concat ", Carbon Version " mac-carbon-version-string))
      (t ""))

Which of the following would be a suitable test to determine whether the
menu-bar is treated as ordinary text lines by `set-frame-size'?

(and (not (eq system-type 'windows-nt)))
     (not (featurep 'x-toolkit)))

(or (featurep 'motif) (featurep 'gtk)
    (boundp 'mac-carbon-version-string))

(or (featurep 'motif) (featurep 'gtk))

Or, if some other test is preferable, please let me know. Thx.

Re: question about testing for toolkit

[Richard Stallman]

    Which of the following would be a suitable test to determine whether the
    menu-bar is treated as ordinary text lines by `set-frame-size'?

    (and (not (eq system-type 'windows-nt)))
	 (not (featurep 'x-toolkit)))

I think that is the best one.  If a toolkit is used,
which toolkit does not matter.

Re: question about testing for toolkit

[Stefan Monnier]

>     Which of the following would be a suitable test to determine whether the
>     menu-bar is treated as ordinary text lines by `set-frame-size'?

>     (and (not (eq system-type 'windows-nt)))
> 	 (not (featurep 'x-toolkit)))

> I think that is the best one.  If a toolkit is used,
> which toolkit does not matter.

I wish no test at all were needed: i.e. the behavior should be the same
regardless.


        Stefan

Re: question about testing for toolkit

[Richard Stallman]

    > I think that is the best one.  If a toolkit is used,
    > which toolkit does not matter.

    I wish no test at all were needed: i.e. the behavior should be the same
    regardless.

Ideally I agree it would be better to change non-toolkit builds to
work the way the toolkit builds to: turning menu bar on or off does
not alter the number of lines available for text.  But does anyone
want to do that much work redesigning non-toolkit X usage?

At some point we might want to desupport that mode instead.
But first we should ask the users how many would be unhappy.