From: Richard Stallman <rms@gnu.org>
To: emacs-devel@gnu.org
Subject: [mp26@os.inf.tu-dresden.de: Patch for sgml-mode.el]
Date: Thu, 22 Nov 2007 23:36:25 -0500 [thread overview]
Message-ID: <E1IvQHB-0007Te-U9@fencepost.gnu.org> (raw)
Would someone please DTRT then ack?
------- Start of forwarded message -------
X-Spam-Status: No, score=0.0 required=5.0 tests=UNPARSEABLE_RELAY
autolearn=failed version=3.1.0
Message-ID: <47457D57.7010008@os.inf.tu-dresden.de>
Date: Thu, 22 Nov 2007 14:00:07 +0100
From: Martin Pohlack <mp26@os.inf.tu-dresden.de>
MIME-Version: 1.0
To: bug-gnu-emacs@gnu.org
Content-Type: multipart/mixed; boundary="------------040006040108080505080703"
Subject: Patch for sgml-mode.el
This is a multi-part message in MIME format.
- --------------040006040108080505080703
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Hi,
sgml-mode.el currently contains such lines:
(define-derived-mode sgml-mode text-mode '(sgml-xml-mode "XML" "SGML")
and
(define-derived-mode html-mode sgml-mode '(sgml-xml-mode "XHTML" "HTML")
.
This violates that the third argument of define-derived-mode shall be a
string. Furthermore, it results in "mode-name" not being a string for
html buffers.
The attached small patch against current CVS fixes these problems.
Cheers,
Martin Pohlack
- --------------040006040108080505080703
Content-Type: text/plain;
name="sgml-mode_mode-name-fix.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="sgml-mode_mode-name-fix.diff"
- --- sgml-mode.el 2007-11-22 13:52:32.000000000 +0100
+++ /usr/share/emacs/23.0.60/lisp/textmodes/sgml-mode.el 2007-11-22 13:50:10.000000000 +0100
@@ -408,7 +406,7 @@
(eq (char-before) ?<))))
;;;###autoload
- -(define-derived-mode sgml-mode text-mode '(sgml-xml-mode "XML" "SGML")
+(define-derived-mode sgml-mode text-mode (if sgml-xml-mode '"XML" '"SGML")
"Major mode for editing SGML documents.
Makes > match <.
Keys <, &, SPC within <>, \", / and ' can be electric depending on
@@ -1890,7 +1888,7 @@
\f
;;;###autoload
- -(define-derived-mode html-mode sgml-mode '(sgml-xml-mode "XHTML" "HTML")
+(define-derived-mode html-mode sgml-mode (if sgml-xml-mode '"XHTML" '"HTML")
"Major mode based on SGML mode for editing HTML documents.
This allows inserting skeleton constructs used in hypertext documents with
completion. See below for an introduction to HTML. Use
- --------------040006040108080505080703--
------- End of forwarded message -------
next reply other threads:[~2007-11-23 4:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-23 4:36 Richard Stallman [this message]
2007-11-23 15:02 ` Fwd: Patch for sgml-mode.el Stefan Monnier
2007-11-23 15:26 ` Martin Pohlack
2007-11-23 16:26 ` Stefan Monnier
2007-11-23 19:55 ` Glenn Morris
2007-11-30 4:46 ` Stefan Monnier
2007-11-30 20:58 ` Glenn Morris
2007-12-01 3:16 ` Stefan Monnier
2007-12-02 21:59 ` Glenn Morris
2007-12-01 4:07 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1IvQHB-0007Te-U9@fencepost.gnu.org \
--to=rms@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.