From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.org!not-for-mail
From: Richard Stallman <rms@gnu.org>
Newsgroups: gmane.emacs.devel
Subject: Re: patch: write-file to arbitrary target directory
Date: Sat, 17 Nov 2007 12:42:38 -0500
Message-ID: <E1ItRgk-0006kv-2W@fencepost.gnu.org>
References: <86r6ip7k4x.fsf@nirvana.pusto.de>
Reply-To: rms@gnu.org
NNTP-Posting-Host: lo.gmane.org
Content-Type: text/plain; charset=ISO-8859-15
X-Trace: ger.gmane.org 1195321375 23333 80.91.229.12 (17 Nov 2007 17:42:55 GMT)
X-Complaints-To: usenet@ger.gmane.org
NNTP-Posting-Date: Sat, 17 Nov 2007 17:42:55 +0000 (UTC)
Cc: emacs-devel@gnu.org
To: Eduard Wiebe <usenet@pusto.de>
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Nov 17 18:43:00 2007
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane.org
Original-Received: from lists.gnu.org ([199.232.76.165])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1ItRh3-0007wg-LY
	for ged-emacs-devel@m.gmane.org; Sat, 17 Nov 2007 18:42:57 +0100
Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43)
	id 1ItRgq-0006qu-Bm
	for ged-emacs-devel@m.gmane.org; Sat, 17 Nov 2007 12:42:44 -0500
Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1ItRgn-0006p3-AX
	for emacs-devel@gnu.org; Sat, 17 Nov 2007 12:42:41 -0500
Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1ItRgl-0006mP-BA
	for emacs-devel@gnu.org; Sat, 17 Nov 2007 12:42:40 -0500
Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ItRgl-0006mB-26
	for emacs-devel@gnu.org; Sat, 17 Nov 2007 12:42:39 -0500
Original-Received: from fencepost.gnu.org ([140.186.70.10])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <rms@gnu.org>) id 1ItRgk-00085i-MJ
	for emacs-devel@gnu.org; Sat, 17 Nov 2007 12:42:38 -0500
Original-Received: from rms by fencepost.gnu.org with local (Exim 4.60)
	(envelope-from <rms@gnu.org>)
	id 1ItRgk-0006kv-2W; Sat, 17 Nov 2007 12:42:38 -0500
In-reply-to: <86r6ip7k4x.fsf@nirvana.pusto.de> (message from Eduard Wiebe on
	Sat, 17 Nov 2007 02:09:34 +0100)
X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4)
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org
Xref: news.gmane.org gmane.emacs.devel:83462
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/83462>

The change looks useful, but there may be a problem.

    ! 	   (let ((dir  (file-name-directory (buffer-name)))
    ! 		 (file (file-name-nondirectory (buffer-name))))

DIR will nearly always be nil, because buffer names normally
do not include directory parts.

Thus, not using default-directory here

    ! 	     (read-file-name "Write file: "
    ! 			     dir (expand-file-name file dir) nil file)))

seems like a bug.  What is the aim of that particular change?


Aside from that, it needs changes in the manual (maybe in more than
one place).