From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: [patch] sort eshell glob matches Date: Mon, 05 Nov 2007 21:16:32 -0500 Message-ID: References: <87r6j5v17z.fsf@localhorst.mine.nu> Reply-To: rms@gnu.org NNTP-Posting-Host: lo.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: ger.gmane.org 1194315747 17350 80.91.229.12 (6 Nov 2007 02:22:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 6 Nov 2007 02:22:27 +0000 (UTC) Cc: David Hansen To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 06 03:22:30 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IpE5C-0003OF-SG for ged-emacs-devel@m.gmane.org; Tue, 06 Nov 2007 03:22:27 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IpE52-0005ae-37 for ged-emacs-devel@m.gmane.org; Mon, 05 Nov 2007 21:22:16 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IpDzW-0001P9-J0 for emacs-devel@gnu.org; Mon, 05 Nov 2007 21:16:34 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IpDzU-0001Nf-Px for emacs-devel@gnu.org; Mon, 05 Nov 2007 21:16:34 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IpDzU-0001NX-KQ for emacs-devel@gnu.org; Mon, 05 Nov 2007 21:16:32 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IpDzU-0007U0-FU for emacs-devel@gnu.org; Mon, 05 Nov 2007 21:16:32 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.60) (envelope-from ) id 1IpDzU-0003kQ-32; Mon, 05 Nov 2007 21:16:32 -0500 In-reply-to: <87r6j5v17z.fsf@localhorst.mine.nu> (message from David Hansen on Mon, 05 Nov 2007 04:08:00 +0100) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:82619 Archived-At: Would someone please DTRT with this, then ack? To: emacs-devel@gnu.org From: David Hansen Date: Mon, 05 Nov 2007 04:08:00 +0100 Organization: disorganized Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Mail-Copies-To: nobody Subject: [patch] sort eshell glob matches --=-=-= Hello, I'm using this patch now for several months w/o problems. I was a bit annoyed that `ogg123 *' played the songs in 'random' and not alphabetical order like w/ bash globing. I can make it customizable if anyone sees a need for it. David --=-=-= Content-Type: text/x-patch Content-Disposition: inline Index: em-glob.el =================================================================== RCS file: /sources/emacs/emacs/lisp/eshell/em-glob.el,v retrieving revision 1.22 diff -c -r1.22 em-glob.el *** em-glob.el 26 Jul 2007 05:26:53 -0000 1.22 --- em-glob.el 5 Nov 2007 03:02:32 -0000 *************** *** 258,264 **** (eshell-glob-entries (file-name-as-directory ".") paths)) (if message-shown (message nil))) ! (or (and matches (nreverse matches)) (if eshell-error-if-no-glob (error "No matches found: %s" glob) glob)))) --- 258,264 ---- (eshell-glob-entries (file-name-as-directory ".") paths)) (if message-shown (message nil))) ! (or (and matches (sort matches #'string<)) (if eshell-error-if-no-glob (error "No matches found: %s" glob) glob)))) Diffs between working revision and workfile end here. --=-=-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel --=-=-=--