* [patch] sort eshell glob matches
@ 2007-11-05 3:08 David Hansen
2007-11-06 2:16 ` Richard Stallman
0 siblings, 1 reply; 3+ messages in thread
From: David Hansen @ 2007-11-05 3:08 UTC (permalink / raw)
To: emacs-devel
[-- Attachment #1: Type: text/plain, Size: 247 bytes --]
Hello,
I'm using this patch now for several months w/o problems. I was a bit
annoyed that `ogg123 *' played the songs in 'random' and not
alphabetical order like w/ bash globing. I can make it customizable if
anyone sees a need for it.
David
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 874 bytes --]
Index: em-glob.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/eshell/em-glob.el,v
retrieving revision 1.22
diff -c -r1.22 em-glob.el
*** em-glob.el 26 Jul 2007 05:26:53 -0000 1.22
--- em-glob.el 5 Nov 2007 03:02:32 -0000
***************
*** 258,264 ****
(eshell-glob-entries (file-name-as-directory ".") paths))
(if message-shown
(message nil)))
! (or (and matches (nreverse matches))
(if eshell-error-if-no-glob
(error "No matches found: %s" glob)
glob))))
--- 258,264 ----
(eshell-glob-entries (file-name-as-directory ".") paths))
(if message-shown
(message nil)))
! (or (and matches (sort matches #'string<))
(if eshell-error-if-no-glob
(error "No matches found: %s" glob)
glob))))
Diffs between working revision and workfile end here.
[-- Attachment #3: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] sort eshell glob matches
2007-11-05 3:08 [patch] sort eshell glob matches David Hansen
@ 2007-11-06 2:16 ` Richard Stallman
2007-11-07 3:58 ` Glenn Morris
0 siblings, 1 reply; 3+ messages in thread
From: Richard Stallman @ 2007-11-06 2:16 UTC (permalink / raw)
To: emacs-devel; +Cc: David Hansen
Would someone please DTRT with this, then ack?
To: emacs-devel@gnu.org
From: David Hansen <david.hansen@gmx.net>
Date: Mon, 05 Nov 2007 04:08:00 +0100
Organization: disorganized
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Mail-Copies-To: nobody
Subject: [patch] sort eshell glob matches
--=-=-=
Hello,
I'm using this patch now for several months w/o problems. I was a bit
annoyed that `ogg123 *' played the songs in 'random' and not
alphabetical order like w/ bash globing. I can make it customizable if
anyone sees a need for it.
David
--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline
Index: em-glob.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/eshell/em-glob.el,v
retrieving revision 1.22
diff -c -r1.22 em-glob.el
*** em-glob.el 26 Jul 2007 05:26:53 -0000 1.22
--- em-glob.el 5 Nov 2007 03:02:32 -0000
***************
*** 258,264 ****
(eshell-glob-entries (file-name-as-directory ".") paths))
(if message-shown
(message nil)))
! (or (and matches (nreverse matches))
(if eshell-error-if-no-glob
(error "No matches found: %s" glob)
glob))))
--- 258,264 ----
(eshell-glob-entries (file-name-as-directory ".") paths))
(if message-shown
(message nil)))
! (or (and matches (sort matches #'string<))
(if eshell-error-if-no-glob
(error "No matches found: %s" glob)
glob))))
Diffs between working revision and workfile end here.
--=-=-=
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
--=-=-=--
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] sort eshell glob matches
2007-11-06 2:16 ` Richard Stallman
@ 2007-11-07 3:58 ` Glenn Morris
0 siblings, 0 replies; 3+ messages in thread
From: Glenn Morris @ 2007-11-07 3:58 UTC (permalink / raw)
To: rms; +Cc: David Hansen, emacs-devel
Richard Stallman wrote:
> Would someone please DTRT with this, then ack?
ack
> To: emacs-devel@gnu.org
> From: David Hansen <david.hansen@gmx.net>
> Date: Mon, 05 Nov 2007 04:08:00 +0100
[...]
> Subject: [patch] sort eshell glob matches
[...]
> I'm using this patch now for several months w/o problems.
Thanks; installed.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-11-07 3:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-11-05 3:08 [patch] sort eshell glob matches David Hansen
2007-11-06 2:16 ` Richard Stallman
2007-11-07 3:58 ` Glenn Morris
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.