From: Richard Stallman <rms@gnu.org>
To: emacs-devel@gnu.org
Cc: David Hansen <david.hansen@gmx.net>
Subject: Re: [patch] sort eshell glob matches
Date: Mon, 05 Nov 2007 21:16:32 -0500 [thread overview]
Message-ID: <E1IpDzU-0003kQ-32@fencepost.gnu.org> (raw)
In-Reply-To: <87r6j5v17z.fsf@localhorst.mine.nu> (message from David Hansen on Mon, 05 Nov 2007 04:08:00 +0100)
Would someone please DTRT with this, then ack?
To: emacs-devel@gnu.org
From: David Hansen <david.hansen@gmx.net>
Date: Mon, 05 Nov 2007 04:08:00 +0100
Organization: disorganized
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Mail-Copies-To: nobody
Subject: [patch] sort eshell glob matches
--=-=-=
Hello,
I'm using this patch now for several months w/o problems. I was a bit
annoyed that `ogg123 *' played the songs in 'random' and not
alphabetical order like w/ bash globing. I can make it customizable if
anyone sees a need for it.
David
--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline
Index: em-glob.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/eshell/em-glob.el,v
retrieving revision 1.22
diff -c -r1.22 em-glob.el
*** em-glob.el 26 Jul 2007 05:26:53 -0000 1.22
--- em-glob.el 5 Nov 2007 03:02:32 -0000
***************
*** 258,264 ****
(eshell-glob-entries (file-name-as-directory ".") paths))
(if message-shown
(message nil)))
! (or (and matches (nreverse matches))
(if eshell-error-if-no-glob
(error "No matches found: %s" glob)
glob))))
--- 258,264 ----
(eshell-glob-entries (file-name-as-directory ".") paths))
(if message-shown
(message nil)))
! (or (and matches (sort matches #'string<))
(if eshell-error-if-no-glob
(error "No matches found: %s" glob)
glob))))
Diffs between working revision and workfile end here.
--=-=-=
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
--=-=-=--
next prev parent reply other threads:[~2007-11-06 2:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-05 3:08 [patch] sort eshell glob matches David Hansen
2007-11-06 2:16 ` Richard Stallman [this message]
2007-11-07 3:58 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1IpDzU-0003kQ-32@fencepost.gnu.org \
--to=rms@gnu.org \
--cc=david.hansen@gmx.net \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.