From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: 23.0.50; eshell/cd and multiple dots in directory name Date: Mon, 05 Nov 2007 01:20:36 -0500 Message-ID: References: <87prysw7bx.fsf@localhorst.mine.nu> Reply-To: rms@gnu.org NNTP-Posting-Host: lo.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: ger.gmane.org 1194243686 15510 80.91.229.12 (5 Nov 2007 06:21:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 5 Nov 2007 06:21:26 +0000 (UTC) Cc: David Hansen To: emacs-pretest-bug@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 05 07:21:29 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IovKz-0003Xu-3L for ged-emacs-devel@m.gmane.org; Mon, 05 Nov 2007 07:21:29 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IovKo-000721-GW for ged-emacs-devel@m.gmane.org; Mon, 05 Nov 2007 01:21:18 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IovKC-0006bi-2C for emacs-devel@gnu.org; Mon, 05 Nov 2007 01:20:40 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IovKA-0006aL-5j for emacs-devel@gnu.org; Mon, 05 Nov 2007 01:20:39 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IovKA-0006aH-0o for emacs-devel@gnu.org; Mon, 05 Nov 2007 01:20:38 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IovK9-0004eO-Gg for emacs-devel@gnu.org; Mon, 05 Nov 2007 01:20:37 -0500 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.60) (envelope-from ) id 1IovK8-00057c-Qf; Mon, 05 Nov 2007 01:20:36 -0500 In-reply-to: <87prysw7bx.fsf@localhorst.mine.nu> (message from David Hansen on Sat, 03 Nov 2007 00:33:54 +0100) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:82546 gmane.emacs.pretest.bugs:20241 Archived-At: I'd like someone to install this on Nov 8 if nobody points out a problem with it before then. From: David Hansen To: emacs-pretest-bug@gnu.org Organization: disorganized Date: Sat, 03 Nov 2007 00:33:54 +0100 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Cc: Subject: 23.0.50; eshell/cd and multiple dots in directory name --=-=-= Please write in English if possible, because the Emacs maintainers usually do not have translators to read other languages for them. Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list. Please describe exactly what actions triggered the bug and the precise symptoms of the bug: Hello, to reproduce: $ emacs -Q M-x eshell RET $ cd /tmp $ mkdir a...b $ cd a...b No such directory found via CDPATH environment variable The error is caused by a call to `eshell-expand-multiple-dots' in `eshell/cd'. I'm not quite sure what the use of `eshell-expand-multiple-dots' is. A quick grep says it's only used in `eshell/cd'. So I suggest the following short patch: --=-=-= Content-Type: text/x-patch Content-Disposition: inline Index: em-dirs.el =================================================================== RCS file: /sources/emacs/emacs/lisp/eshell/em-dirs.el,v retrieving revision 1.21 diff -c -r1.21 em-dirs.el *** em-dirs.el 26 Jul 2007 05:26:53 -0000 1.21 --- em-dirs.el 2 Nov 2007 23:30:36 -0000 *************** *** 319,325 **** (before translate-multiple-dots (filename &optional directory) activate) (setq filename (eshell-expand-multiple-dots filename)))" ! (while (string-match "\\.\\.\\(\\.+\\)" path) (let* ((extra-dots (match-string 1 path)) (len (length extra-dots)) replace-text) --- 319,325 ---- (before translate-multiple-dots (filename &optional directory) activate) (setq filename (eshell-expand-multiple-dots filename)))" ! (while (string-match "\\(?:^\\|/\\)\\.\\.\\(\\.+\\)\\(?:$\\|/\\)" path) (let* ((extra-dots (match-string 1 path)) (len (length extra-dots)) replace-text) Diffs between working revision and workfile end here. --=-=-= Actually I suggest to drop this confusing feature or at least implement it everywhere in eshell (`eshell/ls', `eshell/cp', ...). David If Emacs crashed, and you have the Emacs process in the gdb debugger, please include the output from the following gdb commands: `bt full' and `xbacktrace'. If you would like to further debug the crash, please read the file /home/dhansen/share/emacs/23.0.50/etc/DEBUG for instructions. In GNU Emacs 23.0.50.1 (i686-pc-linux-gnu) of 2007-10-28 on robotron Windowing system distributor `The X.Org Foundation', version 11.0.10400000 configured using `configure '--prefix=/home/dhansen' '--disable-sound' '--disable-pop' '--with-x-toolkit=no'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: en_US.UTF-8 value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: en_US.UTF-8 locale-coding-system: utf-8 default-enable-multibyte-characters: t Major mode: Emacs-Lisp Minor modes in effect: shell-dirtrack-mode: t paredit-mode: t TeX-PDF-mode: t jabber-activity-mode: t eldoc-mode: t which-function-mode: t show-paren-mode: t iswitchb-mode: t tooltip-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t unify-8859-on-encoding-mode: t utf-translate-cjk-mode: t auto-compression-mode: t line-number-mode: t abbrev-mode: 1 hs-minor-mode: t Recent input: C-p C-p C-a RET C-x 1 C-n C-n C-e C-a d SPC C-c m C-x 1 C-n q g C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n RET RET q M-x r g r C-g g C-g f C-h f r g r e p q C-g g C-z c d SPC t m m k d i r SPC a . . . b c d SPC a . . . b C-h f e s h e l l / c d C-c f C-u C-c f C-g C-c f f C-c f f C-c f e C-c d C-g C-c g C-g C-c g C-g C-c v f C-x C-f ~ / d o e m c o n e m d o e m C-s f i n d - f u n C-a C-z f i n d - f u n d c C-a C-k C-n C-n C-n C-n C-n C-n C-u C-M-x M-p n C-x 1 C-x b n n n n n n n n n n n n n n n n n n n n n n n n n n n N G C-x b C-s m u l M-b M-b C-c C-f f C-n C-n C-n C-n C-n M-x r e p o r b u g Recent messages: Result: nil [2 times] Result: "a...b" [2 times] Result: "a../..b" edebug-recursive-edit: Buffer is read-only: # Go-Nonstop... Mark saved where search started uncompressing em-dirs.el.gz...done Fontifying em-dirs.el.gz... (regexps...........................) uncompressing em-dirs.el.gz...done Auto-saving...done --=-=-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel --=-=-=--