* Box cursor incorrectly drawn on stippled stretch glyphs
@ 2007-10-24 14:58 Johan Bockgård
2007-10-25 9:01 ` Richard Stallman
0 siblings, 1 reply; 3+ messages in thread
From: Johan Bockgård @ 2007-10-24 14:58 UTC (permalink / raw)
To: emacs-devel
BUG:
$ emacs -Q
(insert (propertize "x\tx" 'font-lock-face '(:stipple (2 2 "\0\1"))))
The box cursor is not draw correctly when placed on the tab.
FIX:
When drawing the cursor, s->stippled_p should be 0. It has already been
given the correct value by the call to x_set_glyph_string_gc in
x_draw_glyph_string, so don't set it in x_draw_stretch_glyph_string.
2007-10-22 Johan Bockgård <bojohan@gnu.org>
* xterm.c, w32term.c, macterm.c (x_draw_stretch_glyph_string):
Don't set s->stippled_p here.
Index: xterm.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/xterm.c,v
retrieving revision 1.963
diff -u -r1.963 xterm.c
--- xterm.c 13 Oct 2007 12:46:21 -0000 1.963
+++ xterm.c 24 Oct 2007 14:44:07 -0000
@@ -2597,7 +2597,6 @@
struct glyph_string *s;
{
xassert (s->first_glyph->type == STRETCH_GLYPH);
- s->stippled_p = s->face->stipple != 0;
if (s->hl == DRAW_CURSOR
&& !x_stretch_cursor_p)
Index: macterm.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/macterm.c,v
retrieving revision 1.236
diff -u -r1.236 macterm.c
--- macterm.c 16 Oct 2007 16:28:38 -0000 1.236
+++ macterm.c 24 Oct 2007 14:44:24 -0000
@@ -3789,7 +3789,6 @@
struct glyph_string *s;
{
xassert (s->first_glyph->type == STRETCH_GLYPH);
- s->stippled_p = s->face->stipple != 0;
if (s->hl == DRAW_CURSOR
&& !x_stretch_cursor_p)
Index: w32term.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/w32term.c,v
retrieving revision 1.273
diff -u -r1.273 w32term.c
--- w32term.c 15 Oct 2007 02:07:50 -0000 1.273
+++ w32term.c 24 Oct 2007 14:44:33 -0000
@@ -2410,7 +2410,6 @@
struct glyph_string *s;
{
xassert (s->first_glyph->type == STRETCH_GLYPH);
- s->stippled_p = s->face->stipple != 0;
if (s->hl == DRAW_CURSOR
&& !x_stretch_cursor_p)
--
Johan Bockgård
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Box cursor incorrectly drawn on stippled stretch glyphs
2007-10-24 14:58 Box cursor incorrectly drawn on stippled stretch glyphs Johan Bockgård
@ 2007-10-25 9:01 ` Richard Stallman
2007-11-01 4:04 ` Glenn Morris
0 siblings, 1 reply; 3+ messages in thread
From: Richard Stallman @ 2007-10-25 9:01 UTC (permalink / raw)
To: emacs-devel
Would someone please install this and ack?
If the code is in Emacs 22, please install the fix in Emacs 22.
To: emacs-devel@gnu.org
From: bojohan+news@dd.chalmers.se (Johan =?utf-8?Q?Bockg=C3=A5rd?=)
Date: Wed, 24 Oct 2007 16:58:47 +0200
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Mail-Copies-To: never
Subject: Box cursor incorrectly drawn on stippled stretch glyphs
BUG:
$ emacs -Q
(insert (propertize "x\tx" 'font-lock-face '(:stipple (2 2 "\0\1"))))
The box cursor is not draw correctly when placed on the tab.
FIX:
When drawing the cursor, s->stippled_p should be 0. It has already been
given the correct value by the call to x_set_glyph_string_gc in
x_draw_glyph_string, so don't set it in x_draw_stretch_glyph_string.
2007-10-22 Johan Bockgård <bojohan@gnu.org>
* xterm.c, w32term.c, macterm.c (x_draw_stretch_glyph_string):
Don't set s->stippled_p here.
Index: xterm.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/xterm.c,v
retrieving revision 1.963
diff -u -r1.963 xterm.c
--- xterm.c 13 Oct 2007 12:46:21 -0000 1.963
+++ xterm.c 24 Oct 2007 14:44:07 -0000
@@ -2597,7 +2597,6 @@
struct glyph_string *s;
{
xassert (s->first_glyph->type == STRETCH_GLYPH);
- s->stippled_p = s->face->stipple != 0;
if (s->hl == DRAW_CURSOR
&& !x_stretch_cursor_p)
Index: macterm.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/macterm.c,v
retrieving revision 1.236
diff -u -r1.236 macterm.c
--- macterm.c 16 Oct 2007 16:28:38 -0000 1.236
+++ macterm.c 24 Oct 2007 14:44:24 -0000
@@ -3789,7 +3789,6 @@
struct glyph_string *s;
{
xassert (s->first_glyph->type == STRETCH_GLYPH);
- s->stippled_p = s->face->stipple != 0;
if (s->hl == DRAW_CURSOR
&& !x_stretch_cursor_p)
Index: w32term.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/w32term.c,v
retrieving revision 1.273
diff -u -r1.273 w32term.c
--- w32term.c 15 Oct 2007 02:07:50 -0000 1.273
+++ w32term.c 24 Oct 2007 14:44:33 -0000
@@ -2410,7 +2410,6 @@
struct glyph_string *s;
{
xassert (s->first_glyph->type == STRETCH_GLYPH);
- s->stippled_p = s->face->stipple != 0;
if (s->hl == DRAW_CURSOR
&& !x_stretch_cursor_p)
--
Johan Bockgård
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Box cursor incorrectly drawn on stippled stretch glyphs
2007-10-25 9:01 ` Richard Stallman
@ 2007-11-01 4:04 ` Glenn Morris
0 siblings, 0 replies; 3+ messages in thread
From: Glenn Morris @ 2007-11-01 4:04 UTC (permalink / raw)
To: rms; +Cc: emacs-devel
Richard Stallman wrote:
> Would someone please install this and ack?
> If the code is in Emacs 22, please install the fix in Emacs 22.
ack
> To: emacs-devel@gnu.org
> From: bojohan+news@dd.chalmers.se (Johan =?utf-8?Q?Bockg=C3=A5rd?=)
> Date: Wed, 24 Oct 2007 16:58:47 +0200
> Mime-Version: 1.0
> Content-Type: text/plain; charset=utf-8
> Mail-Copies-To: never
> Subject: Box cursor incorrectly drawn on stippled stretch glyphs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-11-01 4:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-24 14:58 Box cursor incorrectly drawn on stippled stretch glyphs Johan Bockgård
2007-10-25 9:01 ` Richard Stallman
2007-11-01 4:04 ` Glenn Morris
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.