From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Richard Stallman Newsgroups: gmane.emacs.devel Subject: Re: isearch multiple buffers Date: Sun, 21 Oct 2007 03:26:47 -0400 Message-ID: References: <87odfcggvl.fsf@jurta.org> <87myut77c2.fsf@jurta.org> <873awlidih.fsf@offby1.atm01.sea.blarg.net> <871wc51any.fsf@jurta.org> <878x6a6ktw.fsf@jurta.org> <871wc15m2b.fsf@jurta.org> <87lk9ylkbb.fsf@jurta.org> Reply-To: rms@gnu.org NNTP-Posting-Host: lo.gmane.org Content-Type: text/plain; charset=ISO-8859-15 X-Trace: ger.gmane.org 1192952662 23619 80.91.229.12 (21 Oct 2007 07:44:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 21 Oct 2007 07:44:22 +0000 (UTC) Cc: emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 21 09:44:23 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IjVTy-0006qL-60 for ged-emacs-devel@m.gmane.org; Sun, 21 Oct 2007 09:44:22 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IjVTq-0003Zi-Kv for ged-emacs-devel@m.gmane.org; Sun, 21 Oct 2007 03:44:14 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IjVNr-0006jJ-Fz for emacs-devel@gnu.org; Sun, 21 Oct 2007 03:38:03 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IjVNk-0006ej-Cn for emacs-devel@gnu.org; Sun, 21 Oct 2007 03:37:56 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IjVNj-0006eP-Na for emacs-devel@gnu.org; Sun, 21 Oct 2007 03:37:55 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IjVNj-0005Li-8A for emacs-devel@gnu.org; Sun, 21 Oct 2007 03:37:55 -0400 Original-Received: from rms by fencepost.gnu.org with local (Exim 4.60) (envelope-from ) id 1IjVCx-0000S5-Ia; Sun, 21 Oct 2007 03:26:47 -0400 In-reply-to: <87lk9ylkbb.fsf@jurta.org> (message from Juri Linkov on Sat, 20 Oct 2007 03:08:08 +0300) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:81354 Archived-At: isearch-multi.el seems like a better name for the new file. Also I implemented a new minor mode isearch-buffers-minor-mode that sets a group of variables necessary for this feature. Turning off this minor mode deletes all created buffer-local bindings. So any major mode that uses this feature can simply set the variable isearch-buffers-next-buffer-function and call isearch-buffers-minor-mode. To make this a minor mode is undesirable because we do not want users to enable and disable it. I think it should simply be a subroution for that major modes can call. ! (if (and (boundp 'isearch-buffers-next-buffer-function) ! isearch-buffers-next-buffer-function ! (boundp 'isearch-buffers-current-buffer) Why test boundp of these variables. Isn't it better to have them always always bound, and just test for non-nil?