From: Richard Stallman <rms@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: rgm@gnu.org, andreas.roehler@online.de, emacs-devel@gnu.org
Subject: Re: Abbrev tables in elisp with some extra stuff
Date: Wed, 17 Oct 2007 16:48:50 -0400 [thread overview]
Message-ID: <E1IiFow-0003Au-16@fencepost.gnu.org> (raw)
In-Reply-To: <jwvejfuygcw.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Tue, 16 Oct 2007 16:26:08 -0400)
+;; - abbrevs could have a `predicate' so you can disable them in strings and
+;; comments, for example. Maybe the predicate should be on the table
+;; rather than on individual abbrevs. This may be enough to cover the
+;; above request for context-dependent abbrevs.
If you implement that on individual abbrevs and on tables,
it will do both jobs.
+(defun abbrev-get (sym prop)
+ (let ((plist (symbol-plist sym)))
+ (if (listp plist)
+ (plist-get plist prop)
+ (if (eq 'count prop) plist))))
That needs a doc string, and the doc string needs
to explain the various types of arguments that are allowed.
+ ;; The loop has to be done via recursion rather than a `while'.
Please add an explanation of why.
+(defun abbrev-set-member (elem set)
That needs a doc string, and it should fully explain
what SET can look like.
+(defun abbrev--active-tables (&optional tables)
That needs a doc string.
It should state the purpose of having the argument TABLES.
Why not just write (or tables (abbrev--active-tables))?
(I don't mind using `abbrev--' to start a function name,
because it has `abbrev' at the beginning.)
+(defun write--abbrev (sym)
I do dislike `--' here since it doesn't start with `abbrev'.
Also please give this a doc string.
next prev parent reply other threads:[~2007-10-17 20:48 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-20 17:48 Abbrev should preserve case Andreas Röhler
2007-06-20 22:18 ` Glenn Morris
2007-06-21 3:47 ` Davis Herring
2007-06-21 4:14 ` Stefan Monnier
2007-06-21 7:10 ` Andreas Röhler
2007-06-21 8:01 ` Stefan Monnier
2007-06-21 9:00 ` Andreas Röhler
2007-06-21 7:00 ` Glenn Morris
2007-06-21 17:32 ` Richard Stallman
2007-06-21 19:02 ` Stefan Monnier
2007-06-22 16:25 ` Richard Stallman
2007-06-22 17:51 ` Stefan Monnier
2007-06-22 21:53 ` Richard Stallman
2007-10-10 21:14 ` Abbrev tables in elisp with some extra stuff (was: Abbrev should preserve case) Stefan Monnier
2007-10-11 19:57 ` Andreas Röhler
2007-10-12 15:59 ` Richard Stallman
2007-10-12 21:26 ` Abbrev tables in elisp with some extra stuff Stefan Monnier
2007-10-13 6:41 ` Richard Stallman
2007-10-14 17:45 ` Andreas Röhler
2007-10-15 16:04 ` Richard Stallman
2007-10-15 18:04 ` Andreas Röhler
2007-10-16 4:10 ` Richard Stallman
2007-10-16 20:26 ` Stefan Monnier
2007-10-17 5:03 ` Richard Stallman
2007-10-17 14:10 ` Richard Stallman
2007-10-17 20:48 ` Richard Stallman [this message]
2007-10-24 2:21 ` Stefan Monnier
2007-10-25 2:10 ` Richard Stallman
2007-10-26 5:44 ` Testing new abbrev tables in elisp Stefan Monnier
2007-10-26 19:13 ` Andreas Röhler
2007-10-26 21:38 ` Stefan Monnier
2007-10-28 14:13 ` Andreas Röhler
2007-10-28 21:03 ` Stefan Monnier
2007-10-30 15:10 ` Andreas Röhler
2007-10-31 7:47 ` Richard Stallman
2007-11-03 20:29 ` Stephen J. Turnbull
2007-11-04 0:11 ` Richard Stallman
2007-11-04 2:42 ` Stephen J. Turnbull
2007-11-04 21:06 ` Andreas Röhler
2007-11-05 8:47 ` Richard Stallman
2007-10-31 16:09 ` Juri Linkov
2007-10-31 17:44 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1IiFow-0003Au-16@fencepost.gnu.org \
--to=rms@gnu.org \
--cc=andreas.roehler@online.de \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.